Skip to content

Commit 01ba3c1

Browse files
tchaikovdenesb
authored andcommitted
Revert "build: don't add nonexistent directory 'lib' to relocatable packages"
This reverts commit 82e3d0c. the "lib" directory is not empty, and it collects all the runtime dependencies for running the java-based nodetool. without them, we'd run into test failures when testing dtests using the java-based nodetool: ``` > raise ToolError(cmd_args, rc, out, err) E ccmlib.node.ToolError: Subprocess ['stress', 'write', 'n=50K', '-rate', 'threads=4', '-node', '127.0.96.1'] exited with non-zero status; exit status: 1; E stderr: Exception in thread "main" java.lang.NoClassDefFoundError: io/netty/util/concurrent/FastThreadLocal E at org.apache.cassandra.stress.Stress.main(Stress.java:59) E Caused by: java.lang.ClassNotFoundException: io.netty.util.concurrent.FastThreadLocal E at java.base/jdk.internal.loader.BuiltinClassLoader.loadClass(BuiltinClassLoader.java:581) E at java.base/jdk.internal.loader.ClassLoaders$AppClassLoader.loadClass(ClassLoaders.java:178) E at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:527) E ... 1 more ``` Closes: #397
1 parent 76a2682 commit 01ba3c1

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

scripts/create-relocatable-package.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -62,6 +62,7 @@ def reloc_add(self, name, arcname=None, recursive=True, *, filter=None):
6262
ar.reloc_add('conf')
6363
ar.reloc_add('bin')
6464
ar.reloc_add('tools')
65+
ar.reloc_add('lib')
6566
ar.reloc_add('doc')
6667
ar.reloc_add('install.sh')
6768
ar.reloc_add('build/apache-cassandra-{}.jar'.format(version), arcname='lib/apache-cassandra-{}.jar'.format(version))

0 commit comments

Comments
 (0)