Skip to content

Commit 5e07326

Browse files
committed
Fixed bugs, updated readme
1 parent 8d21389 commit 5e07326

File tree

5 files changed

+13
-9
lines changed

5 files changed

+13
-9
lines changed

README.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -69,6 +69,10 @@ In general, every record consists of:
6969

7070
### Changelog
7171

72+
#### 1.1.3
73+
- Fixed a critical bug that extension wouldn't work if specific key wasn't already present due to misplaced early return
74+
- Fixed a smaller bug that details wouldn't be shown on deletion confirmation prompt
75+
7276
#### 1.1.2
7377
- Moved settings to popup, since the top bar was getting crowded
7478
- Moved editing records to popup, since the main table was getting really crowded

RecordStorage.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -89,13 +89,13 @@ class RecordStorage {
8989
async forGeneralProperties(callback){
9090
let __callback = (result) => {
9191
if(!result || !result.ScheduleBlock_Properties){
92-
return;
92+
callback({});
93+
}else{
94+
callback(result.ScheduleBlock_Properties);
9395
}
94-
callback(result.ScheduleBlock_Properties);
9596
}
9697

9798
await chrome.storage.sync.get(['ScheduleBlock_Properties'], __callback);
98-
return 0;
9999
}
100100

101101
async setGeneralProperties(newProperties, extraCallback = ()=>{}){

manifest.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"name": "ScheduleBlock",
33
"description": "Block websites on a schedule",
4-
"version": "1.1.2",
4+
"version": "1.1.3",
55
"manifest_version": 3,
66
"permissions": ["storage"],
77
"content_scripts" : [{

manifestff.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"name": "ScheduleBlock",
33
"description": "Block websites on a schedule",
4-
"version": "1.1.2",
4+
"version": "1.1.3",
55
"manifest_version": 2,
66
"permissions": ["storage"],
77
"content_scripts" : [{

options.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -388,10 +388,10 @@ document.getElementById("export").addEventListener("click", rs.exportSettings);
388388
return rec;
389389

390390
if(confirm(tp.getTranslatedString(305)
391-
.format(rec.regex,
392-
rec.destination,
393-
rec.softhours,
394-
rec.hardhours))){
391+
.format(rec.getRegex(),
392+
rec.getDestination(),
393+
rec.getSoftHours(),
394+
rec.getHardHours()))){
395395
alreadyDeleted = true;
396396
return false;
397397
}

0 commit comments

Comments
 (0)