Skip to content

Commit ddd5ff8

Browse files
authored
Feature: UI Improvement Idea (issue #385) (#387)
A few updates to UI as discussed earlier to add clarity and unity. Signed-off-by: Daixuan <[email protected]>
1 parent 35b512a commit ddd5ff8

File tree

1 file changed

+5
-3
lines changed

1 file changed

+5
-3
lines changed

NeuralAmpModeler/NeuralAmpModeler.cpp

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@ NeuralAmpModeler::NeuralAmpModeler(const InstanceInfo& info)
7575
GetParam(kToneMid)->InitDouble("Middle", 5.0, 0.0, 10.0, 0.1);
7676
GetParam(kToneTreble)->InitDouble("Treble", 5.0, 0.0, 10.0, 0.1);
7777
GetParam(kOutputLevel)->InitGain("Output", 0.0, -40.0, 40.0, 0.1);
78-
GetParam(kNoiseGateThreshold)->InitGain("Gate", -80.0, -100.0, 0.0, 0.1);
78+
GetParam(kNoiseGateThreshold)->InitGain("Threshold", -80.0, -100.0, 0.0, 0.1);
7979
GetParam(kNoiseGateActive)->InitBool("NoiseGateActive", true);
8080
GetParam(kEQActive)->InitBool("ToneStack", true);
8181
GetParam(kOutNorm)->InitBool("OutNorm", true);
@@ -164,7 +164,9 @@ NeuralAmpModeler::NeuralAmpModeler(const InstanceInfo& info)
164164

165165
// Misc Areas
166166
const auto helpButtonArea = mainArea.GetFromTRHC(50, 50).GetCentredInside(20, 20);
167-
const auto sampleRateWarningArea = inputMeterArea.GetFromBottom(16.f).GetTranslated(12.f, 16.f).GetFromLeft(300.f);
167+
// Making it centered under the big title
168+
const auto sampleRateWarningArea = titleArea.GetFromBottom(16.f).GetTranslated(117.f, 6.f).GetFromLeft(300.f);
169+
//modelArea.GetFromBottom(16.f).GetTranslated(12.f, 16.f).GetFromLeft(300.f);
168170

169171
// Model loader button
170172
auto loadModelCompletionHandler = [&](const WDL_String& fileName, const WDL_String& path) {
@@ -221,7 +223,7 @@ NeuralAmpModeler::NeuralAmpModeler(const InstanceInfo& info)
221223
new NAMFileBrowserControl(irArea, kMsgTagClearIR, defaultIRString.c_str(), "wav", loadIRCompletionHandler, style,
222224
fileSVG, crossSVG, leftArrowSVG, rightArrowSVG, fileBackgroundBitmap),
223225
kCtrlTagIRFileBrowser);
224-
pGraphics->AttachControl(new NAMSwitchControl(ngToggleArea, kNoiseGateActive, " ", style, switchHandleBitmap));
226+
pGraphics->AttachControl(new NAMSwitchControl(ngToggleArea, kNoiseGateActive, "Noise Gate", style, switchHandleBitmap));
225227
pGraphics->AttachControl(new NAMSwitchControl(eqToggleArea, kEQActive, "EQ", style, switchHandleBitmap));
226228
pGraphics->AttachControl(
227229
new NAMSwitchControl(outNormToggleArea, kOutNorm, "Normalize", style, switchHandleBitmap), kCtrlTagOutNorm);

0 commit comments

Comments
 (0)