Skip to content

Commit 475a97d

Browse files
findepisadboy
authored andcommitted
Snapshot PR: Extract complex default impls from AggregateUDFImpl trait
Extract AggregateUDFImpl method that have complex implementations. This makes it feasible to implement that trait with `#[warn(clippy::missing_trait_methods)]` Clippy check enabled. That check is very helpful when the type implementing `AggregateUDFImpl` delegates many methods to another `AggregateUDFImpl` implementation and therefore does not want to unconsciously rely on default implementation. Sadly, Rust does not allow explicitly delegating to trait method's default implementation. Extracting the logic to standalone functions works around that limitation.
1 parent 2caeabd commit 475a97d

File tree

1 file changed

+272
-231
lines changed

1 file changed

+272
-231
lines changed

0 commit comments

Comments
 (0)