TMP: Disable qualified names uniqueness check in schema

Author: findepi

datafusion/common/src/dfschema.rs

@@ -233,10 +233,11 @@ impl DFSchema {
         for (field, qualifier) in self.inner.fields().iter().zip(&self.field_qualifiers) {
             if let Some(qualifier) = qualifier {
                 if !qualified_names.insert((qualifier, field.name())) {
-                    return _schema_err!(SchemaError::DuplicateQualifiedField {
-                        qualifier: Box::new(qualifier.clone()),
-                        name: field.name().to_string(),
-                    });
+                    // TODO properly revert or restore this error
+                    // return _schema_err!(SchemaError::DuplicateQualifiedField {
+                    //     qualifier: Box::new(qualifier.clone()),
+                    //     name: field.name().to_string(),
+                    // });
                 }
             } else if !unqualified_names.insert(field.name()) {
                 return _schema_err!(SchemaError::DuplicateUnqualifiedField {
@@ -1257,10 +1258,7 @@ mod tests {
         let left = DFSchema::try_from_qualified_schema("t1", &test_schema_1())?;
         let right = DFSchema::try_from_qualified_schema("t1", &test_schema_1())?;
         let join = left.join(&right);
-        assert_eq!(
-            join.unwrap_err().strip_backtrace(),
-            "Schema error: Schema contains duplicate qualified field name t1.c0",
-        );
+        assert!(join.is_ok());
         Ok(())
     }
 

datafusion/sqllogictest/test_files/join.slt.part

@@ -1237,14 +1237,18 @@ statement ok
 create table t1(v1 int) as values(100);
 
 ## Query with Ambiguous column reference
-query error DataFusion error: Schema error: Schema contains duplicate qualified field name t1\.v1
+query I
 select count(*)
 from t1
 right outer join t1
 on t1.v1 > 0;
+----
+1
 
-query error DataFusion error: Schema error: Schema contains duplicate qualified field name t1\.v1
+query I
 select t1.v1 from t1 join t1 using(v1) cross join (select struct('foo' as v1) as t1);
+----
+100
 
 statement ok
 drop table t1;