You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When the pr-report shows a problem in a PR in either of these repos, you need to fix the problem before you can approve the PR.
4
11
5
12
The problems that will break our build are:
6
13
@@ -11,7 +18,7 @@ Before the PR can be approved, we need to make sure that the docs that reference
11
18
12
19
There are various ways to fix the problem, depending on the situation. These are outlined in the sections below.
13
20
14
-
> During a docs freeze (before Build or Ignite), don't approve any azureml-examples PRs that have problems - we can't fix them on our end during this time. If they deleted a file, have them put it back. If they deleted an ID or cell name, have them put it back, even if there are no contents in the section or cell.
21
+
> During a docs freeze (before Build or Ignite), don't approve any PRs that have problems - we can't fix them on our end during this time. If they deleted a file, have them put it back. If they deleted an ID or cell name, have them put it back, even if there are no contents in the section or cell.
15
22
>
16
23
## Push back - why is the change needed?
17
24
@@ -56,18 +63,18 @@ If you can quickly fix the reference in azure-ai-docs-pr, do so. For example, i
56
63
* Create a PR in azure-ai-docs-pr to apply this fix.
57
64
* After your azure-ai-docs-pr PR with the fix is merged, you can approve the azureml-examples PR.
58
65
59
-
> NOTE FOR RELEASE BRANCHES: During Build or Ignite, when there are release branches, this process is more complex. All those release branches also need your update. Coordinate with the Build/Ignite roadshow owner before you approve the azureml-examples PR. They'll need to sync main into the release branches before you can approve the original azureml-examples PR.
66
+
> NOTE FOR RELEASE BRANCHES: During Build or Ignite, when there are release branches, this process is more complex. All those release branches also need your update. Coordinate with the Build/Ignite roadshow owner before you approve the code repo's PR. They'll need to sync main into all release branches before you can approve the original code repo PR.
60
67
61
68
## Move to a temporary branch
62
69
63
70
If you can't do a quick fix, follow this process:
64
71
65
72
1. If temp-fix has the same version of the file, skip 2 and proceed to #3.
66
-
1. If temp-fix does not have the same version of the file, use the steps below to first [update the temp-fix branch](#temp-fix) in azureml-examples.
73
+
1. If temp-fix does not have the same version of the file, use the steps below to first [update the temp-fix branch](#temp-fix) in the code repo.
67
74
1. <aname="three"></a> Create a PR in azure-ai-docs-pr to use **~/azureml-examples-temp-fix** instead of **~/azureml-examples-main** for the reference(s) to the problem file/id(s).
68
-
1. Once your PR in azure-ai-docs-pr is merged to main, you can approve the azureml-examples PR.
69
-
> NOTE FOR RELEASE BRANCHES: During Build or Ignite, when there are release branches, this process is more complex. All those release branches also need your update. Coordinate with the Build/Ignite roadshow owner before you approve the azureml-examples PR. They'll need to sync main into the release branches before you can approve the original azureml-examples PR.
70
-
1. Create a work item to update these articles to again use ~/azureml-examples-main after the azureml-examples PR has merged. We want to minimize the time that an article references a file on the temp-fix branch.
75
+
1. Once your PR in azure-ai-docs-pr is merged to main, you can approve the code repo PR.
76
+
> NOTE FOR RELEASE BRANCHES: During Build or Ignite, when there are release branches, this process is more complex. All those release branches also need your update. Coordinate with the Build/Ignite roadshow owner before you approve the azureml-examples PR. They'll need to sync main into the release branches before you can approve the original code repo PR.
77
+
1. Create a work item to update these articles to again use ~/azureml-examples-main or ~/foundry-samples-main after the azureml-examples PR has merged. We want to minimize the time that an article references a file on the temp-fix branch.
71
78
### Example
72
79
73
80
You'll see the following output from `python GitHub/pr-report.py 2888`:
0 commit comments