Skip to content

Commit 3321af7

Browse files
Oliver Weilermarc0der
authored andcommitted
Declare sdkmanrc as a local, readonly variable
1 parent a49f7e7 commit 3321af7

File tree

1 file changed

+13
-10
lines changed

1 file changed

+13
-10
lines changed

src/main/bash/sdkman-env.sh

Lines changed: 13 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -17,16 +17,17 @@
1717
#
1818

1919
function __sdk_env() {
20-
SDKMANRC=".sdkmanrc"
20+
local -r sdkmanrc=".sdkmanrc"
21+
local sub_command="$1"
2122

22-
if [[ "$1" == "init" ]]; then
23-
__sdkman_generate_sdkmanrc
23+
if [[ "$sub_command" == "init" ]]; then
24+
__sdkman_generate_sdkmanrc "$sdkmanrc"
2425

2526
return 0
2627
fi
2728

28-
if [[ ! -f "$SDKMANRC" ]]; then
29-
__sdkman_echo_red "Could not find $SDKMANRC in the current directory."
29+
if [[ ! -f "$sdkmanrc" ]]; then
30+
__sdkman_echo_red "Could not find $sdkmanrc in the current directory."
3031
echo ""
3132
__sdkman_echo_yellow "Run 'sdk env init' to create it."
3233

@@ -48,12 +49,14 @@ function __sdk_env() {
4849
fi
4950

5051
__sdk_use "${normalised_line%=*}" "${normalised_line#*=}"
51-
done < "$SDKMANRC"
52+
done < "$sdkmanrc"
5253
}
5354

5455
function __sdkman_generate_sdkmanrc() {
55-
if [[ -f "$SDKMANRC" ]]; then
56-
__sdkman_echo_red "$SDKMANRC already exists!"
56+
local -r sdkmanrc="$1"
57+
58+
if [[ -f "$sdkmanrc" ]]; then
59+
__sdkman_echo_red "$sdkmanrc already exists!"
5760

5861
return 1
5962
fi
@@ -63,9 +66,9 @@ function __sdkman_generate_sdkmanrc() {
6366
local version
6467
[[ -n "$CURRENT" ]] && version="$CURRENT" || version="$(__sdkman_secure_curl "${SDKMAN_CANDIDATES_API}/candidates/default/java")"
6568

66-
echo "java=$version" > "$SDKMANRC"
69+
echo "java=$version" > "$sdkmanrc"
6770

68-
__sdkman_echo_green "$SDKMANRC created."
71+
__sdkman_echo_green "$sdkmanrc created."
6972
}
7073

7174
function __sdkman_is_blank_line() {

0 commit comments

Comments
 (0)