Skip to content

Commit 5a8c2f4

Browse files
committed
Refine platform handling in tests.
1 parent 3bae641 commit 5a8c2f4

File tree

3 files changed

+12
-13
lines changed

3 files changed

+12
-13
lines changed

src/test/groovy/sdkman/steps/initialisation_steps.groovy

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@ And(~'^offline mode is enabled with unreachable internet$') { ->
8181
And(~'^a machine with "(.*)" installed$') { String platform ->
8282
def binFolder = "$sdkmanBaseDir/bin" as File
8383
UnameStub.prepareIn(binFolder)
84-
.forPlatform(asSdkmanPlatform(platform, null))
84+
.forPlatform(asSdkmanPlatform(platform))
8585
.build()
8686
}
8787

src/test/groovy/sdkman/steps/stub_steps.groovy

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -28,13 +28,13 @@ And(~'^the candidate "([^"]*)" version "([^"]*)" is available for download$') {
2828
}
2929

3030
And(~/^the appropriate universal hooks are available for "([^"]*)" version "([^"]*)" on "([^"]*)"$/) { String candidate, String version, String platform ->
31-
String lcPlatform = UnixUtils.asSdkmanPlatform(platform, null).toLowerCase()
31+
String lcPlatform = UnixUtils.asSdkmanPlatform(platform).toLowerCase()
3232
primeUniversalHookFor("pre", candidate, version, lcPlatform)
3333
primeUniversalHookFor("post", candidate, version, lcPlatform)
3434
}
3535

3636
And(~/^the appropriate multi-platform hooks are available for "([^"]*)" version "([^"]*)" on "([^"]*)"$/) { String candidate, String version, String platform ->
37-
String lcPlatform = UnixUtils.asSdkmanPlatform(platform, null).toLowerCase()
37+
String lcPlatform = UnixUtils.asSdkmanPlatform(platform).toLowerCase()
3838
primePlatformSpecificHookFor("pre", candidate, version, lcPlatform)
3939
primePlatformSpecificHookFor("post", candidate, version, lcPlatform)
4040
}
@@ -44,23 +44,23 @@ And(~'^the candidate "([^"]*)" version "([^"]*)" is not available for download$'
4444
}
4545

4646
And(~/^the candidate "(.*)" version "(.*)" is available for download on "(.*)"$/) { String candidate, String version, String platform ->
47-
String lcPlatform = UnixUtils.asSdkmanPlatform(platform, null).toLowerCase()
47+
String lcPlatform = UnixUtils.asSdkmanPlatform(platform).toLowerCase()
4848
primeEndpointWithString("/candidates/validate/${candidate}/${version}/${lcPlatform}", "valid")
4949
primeDownloadFor(SERVICE_UP_URL, candidate, version, lcPlatform)
5050
}
5151

5252
And(~/^a "([^"]*)" install hook is served for "([^"]*)" "([^"]*)" on "([^"]*)" that returns successfully$/) { String phase, String candidate, String version, String platform ->
53-
String lcPlatform = UnixUtils.asSdkmanPlatform(platform, null).toLowerCase()
53+
String lcPlatform = UnixUtils.asSdkmanPlatform(platform).toLowerCase()
5454
primeEndpointWithString("/hooks/${phase}/${candidate}/${version}/${lcPlatform}", phase == "pre" ? preInstallationHookSuccess() : postInstallationHookSuccess())
5555
}
5656

5757
And(~/^a "([^"]*)" install hook is served for "([^"]*)" "([^"]*)" on "([^"]*)" that returns a failure$/) { String phase, String candidate, String version, String platform ->
58-
String lcPlatform = UnixUtils.asSdkmanPlatform(platform, null).toLowerCase()
58+
String lcPlatform = UnixUtils.asSdkmanPlatform(platform).toLowerCase()
5959
primeEndpointWithString("/hooks/${phase}/${candidate}/${version}/${lcPlatform}", phase == "pre" ? preInstallationHookFailure() : postInstallationHookFailure())
6060
}
6161

6262
And(~/^the candidate "(.*?)" version "(.*?)" is not available for download on "(.*?)"$/) { String candidate, String version, String platform ->
63-
String lcPlatform = UnixUtils.asSdkmanPlatform(platform, null).toLowerCase()
63+
String lcPlatform = UnixUtils.asSdkmanPlatform(platform).toLowerCase()
6464
primeEndpointWithString("/candidates/validate/${candidate}/${version}/${lcPlatform}", "invalid")
6565
}
6666

src/test/groovy/sdkman/support/UnixUtils.groovy

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -6,13 +6,12 @@ class UnixUtils {
66
asSdkmanPlatform(System.getProperty("os.name"), System.getProperty("os.arch"))
77
}
88

9-
static asSdkmanPlatform(platform, architecture) {
10-
if("aarch64" == architecture) {
11-
platform += architecture
12-
}
9+
static asSdkmanPlatform(platform, architecture = "") {
10+
11+
def platformArch = architecture == "aarch64" ? "$platform $architecture" : platform
1312

1413
def result
15-
switch (platform) {
14+
switch (platformArch) {
1615
case "Mac OS X":
1716
result = "Darwin"
1817
break
@@ -25,7 +24,7 @@ class UnixUtils {
2524
case "Linux 32":
2625
result = "Linux32"
2726
break
28-
case "Linuxaarch64":
27+
case "Linux aarch64":
2928
result = "LinuxARM64"
3029
break
3130
case "FreeBSD":

0 commit comments

Comments
 (0)