Save HTTP response headers under ${SDKMAN}/var/metadata

Author: hgeraldino

src/main/bash/sdkman-flush.sh

@@ -38,9 +38,13 @@ function __sdk_flush() {
 	tmp)
 		__sdkman_cleanup_folder "tmp"
 		;;
+	metadata)
+    	__sdkman_cleanup_folder "var/metadata"
+    	;;
 	*)
 		__sdkman_cleanup_folder "archives"
 		__sdkman_cleanup_folder "tmp"
+		__sdkman_cleanup_folder "var/metadata"
 		;;
 	esac
 }

src/main/bash/sdkman-install.sh

@@ -120,11 +120,15 @@ function __sdkman_download() {
 	version="$2"
 
 	archives_folder="${SDKMAN_DIR}/archives"
+	metadata_folder="${SDKMAN_DIR}/var/metadata"
+	mkdir -p ${metadata_folder}
+	
 	if [ ! -f "${archives_folder}/${candidate}-${version}.zip" ]; then
 		local platform_parameter="$(echo $SDKMAN_PLATFORM | tr '[:upper:]' '[:lower:]')"
 		local download_url="${SDKMAN_CANDIDATES_API}/broker/download/${candidate}/${version}/${platform_parameter}"
 		local base_name="${candidate}-${version}"
 		local zip_archive_target="${SDKMAN_DIR}/archives/${candidate}-${version}.zip"
+		local headers="${metadata_folder}/${base_name}.headers"
 
 		# pre-installation hook: implements function __sdkman_pre_installation_hook
 		local pre_installation_hook="${SDKMAN_DIR}/tmp/hook_pre_${candidate}_${version}.sh"
@@ -145,8 +149,8 @@ function __sdkman_download() {
 		echo ""
 
 		# download binary
-		__sdkman_secure_curl_download "${download_url}" --output "${binary_input}"
-		__sdkman_echo_debug "Downloaded binary to: ${binary_input}"
+		__sdkman_secure_curl_download "${download_url}" --output "${binary_input}" --dump-header "${headers}"
+		__sdkman_echo_debug "Downloaded binary to: ${binary_input} (HTTP headers written to: ${headers})"
 
 		# post-installation hook: implements function __sdkman_post_installation_hook
 		# responsible for taking `binary_input` and producing `zip_output`

src/test/groovy/sdkman/env/SdkmanBashEnvBuilder.groovy

@@ -30,8 +30,9 @@ class SdkmanBashEnvBuilder {
 			sdkman_beta_channel: 'false'
 	]
 
-	File sdkmanDir, sdkmanBinDir, sdkmanVarDir, sdkmanSrcDir, sdkmanEtcDir, sdkmanExtDir, sdkmanArchivesDir, sdkmanTmpDir, sdkmanCandidatesDir
-
+	File sdkmanDir, sdkmanBinDir, sdkmanVarDir, sdkmanSrcDir, sdkmanEtcDir, sdkmanExtDir, sdkmanArchivesDir,
+		 sdkmanTmpDir, sdkmanCandidatesDir, sdkmanMetadataDir
+	
 	static SdkmanBashEnvBuilder create(File baseFolder) {
 		new SdkmanBashEnvBuilder(baseFolder)
 	}
@@ -110,6 +111,7 @@ class SdkmanBashEnvBuilder {
 		sdkmanArchivesDir = prepareDirectory(sdkmanDir, "archives")
 		sdkmanTmpDir = prepareDirectory(sdkmanDir, "tmp")
 		sdkmanCandidatesDir = prepareDirectory(sdkmanDir, "candidates")
+		sdkmanMetadataDir = prepareDirectory(sdkmanVarDir, "metadata")
 
 		curlStub.map { it.build() }
 		unameStub.map { it.build() }

src/test/groovy/sdkman/steps/env.groovy

@@ -31,6 +31,7 @@ candidatesDir = "${sdkmanDirEnv}/candidates" as File
 binDir = "${sdkmanDirEnv}/bin" as File
 srcDir = "${sdkmanDirEnv}/src" as File
 varDir = "${sdkmanDirEnv}/var" as File
+metadataDir = "${varDir}/metadata" as File
 etcDir = "${sdkmanDirEnv}/etc" as File
 extDir = "${sdkmanDirEnv}/ext" as File
 archiveDir = "${sdkmanDirEnv}/archives" as File

src/test/groovy/sdkman/steps/flush_steps.groovy

@@ -38,3 +38,11 @@ And(~'^no version file can be found$') { ->
 And(~'^the Remote Version has been flushed$') { ->
 	assert versionFile.delete()
 }
+
+And(~'^a headers file "([^"]*)" in metadata directory$') { String fileName ->
+	new File(metadataDir, fileName).createNewFile()
+}
+
+And(~'^no metadata is cached$') { ->
+	assert !metadataDir.listFiles()
+}

src/test/groovy/sdkman/steps/installation_steps.groovy

@@ -96,3 +96,15 @@ And(~'^I have configured "([^"]*)" to "([^"]*)"$') { String configName, String f
 And(~/^the exit code is (\d+)$/) { Integer rc ->
 	assert bash.getStatus() == rc
 }
+
+And(~'^the response headers file is created for candidate "([^"]*)" and version "([^"]*)"$') { String candidate, String version ->
+	def headersFile = "${metadataDir}/${candidate}-${version}.headers" as File
+	if (!headersFile.exists()) println bash.output
+	assert headersFile.exists()
+}
+
+And(~'^no response headers are written for candidate "([^"]*)" and version "([^"]*)"$') { String candidate, String version ->
+	def headersFile = "${metadataDir}/${candidate}-${version}.headers" as File
+	if (headersFile.exists()) println bash.output
+	assert !headersFile.exists()
+}

src/test/resources/features/flush.feature

@@ -5,12 +5,14 @@ Feature: Flush
 		And an initialised environment
 		And the system is bootstrapped
 
-	Scenario: Clear out the cached archives and the temporary storage
+	Scenario: Clear out the cached archives, the temporary storage and metadata
 		Given the archive "grails-1.3.9.zip" has been cached
 		And the file "res-1.2.0.zip" in temporary storage
+		And a headers file "grails-1.3.9.headers" in metadata directory
 		When I enter "sdk flush"
 		Then no archives are cached
 		And no "res-1.2.0.zip" file is present in temporary storage
+		And no metadata is cached
 		And I see "1 archive(s) flushed"
 		And I see "1 archive(s) flushed"
 
@@ -42,3 +44,9 @@ Feature: Flush
 		When I enter "sdk flush temp"
 		Then no "res-1.2.0.zip" file is present in temporary storage
 		And I see "1 archive(s) flushed"
+
+	Scenario: Clear out the metadata
+		Given a headers file "grails-1.3.9.headers" in metadata directory
+		When I enter "sdk flush metadata"
+		Then no metadata is cached
+		And I see "1 archive(s) flushed"	

src/test/resources/features/install_candidate.feature

@@ -12,6 +12,7 @@ Feature: Install Candidate
 		Then I see "Done installing!"
 		And I do not see "Do you want grails 2.1.0 to be set as default? (Y/n)"
 		And the candidate "grails" version "2.1.0" is installed
+		And the response headers file is created for candidate "grails" and version "2.1.0"
 		And the exit code is 0
 
 	Scenario: Install a specific Candidate and set to default
@@ -21,6 +22,7 @@ Feature: Install Candidate
 		Then I see "Done installing!"
 		And I do not see "Do you want grails 1.3.9 to be set as default? (Y/n)"
 		And the candidate "grails" version "1.3.9" is installed
+		And the response headers file is created for candidate "grails" and version "1.3.9"
 		And the exit code is 0
 
 	Scenario: Install a Candidate version that does not exist
@@ -36,6 +38,7 @@ Feature: Install Candidate
 		And the candidate "grails" version "1.3.9" is already installed and default
 		When I enter "sdk install grails 1.3.9"
 		Then I see "grails 1.3.9 is already installed."
+		And no response headers are written for candidate "grails" and version "1.3.9"
 		And the exit code is 0
 
 	Scenario: Install a candidate and auto-answer to make it default
@@ -44,6 +47,7 @@ Feature: Install Candidate
 		And I have configured "sdkman_auto_answer" to "true"
 		When I enter "sdk install grails 2.1.0"
 		Then the candidate "grails" version "2.1.0" is installed
+		And the response headers file is created for candidate "grails" and version "2.1.0"
 		And I do not see "Do you want grails 2.1.0 to be set as default?"
 		And I see "Done installing!"
 		And I see "Setting grails 2.1.0 as default."
@@ -56,6 +60,7 @@ Feature: Install Candidate
 		And the candidate "grails" version "2.1.0" is available for download
 		When I enter "sdk install grails 2.1.0" and answer "Y"
 		Then the candidate "grails" version "2.1.0" is installed
+		And the response headers file is created for candidate "grails" and version "2.1.0"
 		And I see "Done installing!"
 		And I see "Do you want grails 2.1.0 to be set as default? (Y/n)"
 		And I see "Setting grails 2.1.0 as default."
@@ -69,6 +74,7 @@ Feature: Install Candidate
 		And the candidate "grails" version "2.1.0" is available for download
 		When I enter "sdk install grails 2.1.0" and answer "n"
 		Then the candidate "grails" version "2.1.0" is installed
+		And the response headers file is created for candidate "grails" and version "2.1.0"
 		And I see "Done installing!"
 		And I see "Do you want grails 2.1.0 to be set as default? (Y/n)"
 		And I do not see "Setting grails 2.1.0 as default."