Do not check and warn of stale candidates cache.

Author: marc0der

src/main/bash/sdkman-cache.sh

@@ -18,20 +18,14 @@
 
 function ___sdkman_check_candidates_cache() {
 	local candidates_cache="$1"
-	if [[ -f "$candidates_cache" && -n "$(< "$candidates_cache")" && -n "$(find "$candidates_cache" -mmin +$((24 * 60 * 30)))" ]]; then
-		__sdkman_echo_yellow 'We periodically need to update the local cache. Please run:'
-		echo ''
-		__sdkman_echo_no_colour '  $ sdk update'
-		echo ''
-		return 0
-	elif [[ -f "$candidates_cache" && -z "$(< "$candidates_cache")" ]]; then
+	if [[ -f "$candidates_cache" && -z "$(< "$candidates_cache")" ]]; then
 		__sdkman_echo_red 'WARNING: Cache is corrupt. SDKMAN cannot be used until updated.'
 		echo ''
 		__sdkman_echo_no_colour '  $ sdk update'
 		echo ''
 		return 1
 	else
-		__sdkman_echo_debug "No update at this time. Using existing cache: $SDKMAN_CANDIDATES_CSV"
+		__sdkman_echo_debug "Using existing cache: $SDKMAN_CANDIDATES_CSV"
 		return 0
 	fi
 }

src/test/groovy/sdkman/specs/CandidatesCacheUpdateSpec.groovy

@@ -39,7 +39,7 @@ class CandidatesCacheUpdateSpec extends SdkmanEnvSpecification {
 		!bash.output.contains("SDKMAN 5.0.0")
 	}
 
-	void "should issue a warning if cache is older than a month"() {
+	void "should NOT issue a warning if cache is older than a month"() {
 		given:
 		bash = sdkmanBashEnvBuilder
 				.withCandidates(['groovy'])
@@ -56,11 +56,11 @@ class CandidatesCacheUpdateSpec extends SdkmanEnvSpecification {
 		bash.execute("sdk help")
 
 		then:
-		bash.output.contains('We periodically need to update the local cache.')
-		bash.output.contains('$ sdk update')
+		!bash.output.contains('We periodically need to update the local cache.')
+		!bash.output.contains('$ sdk update')
 	}
 
-	void "should log a success message in debug mode when no update needed"() {
+	void "should log a success message if cache exists"() {
 		given:
 		bash = sdkmanBashEnvBuilder
 				.withCandidates(['groovy'])
@@ -74,7 +74,7 @@ class CandidatesCacheUpdateSpec extends SdkmanEnvSpecification {
 		bash.execute("sdk help")
 
 		then:
-		bash.output.contains('No update at this time. Using existing cache')
+		bash.output.contains('Using existing cache')
 	}
 
 	void "should bypass cache check if update command issued"() {