Bug: Installer does not check for find command

[bambuchaAdm]

Bug report
During installation sdkman checks for few tools that are required to correct work. In my case it catch lack of zip and unzip, but did not report absens of find command. It would be nice if installer also check for find when internally it used. This is specially worth in very stripped systems.

To reproduce
Run shell in slim linux container using docker/podman

podman run -it docker.io/oraclelinux:8-slim

in shell

microdnf update
microdnf install unzip zip
curl -s "https://get.sdkman.io?ci=true" | bash
source "/root/.sdkman/bin/sdkman-init.sh"

Last command give output

bash: find: command not found
bash: __sdkman_echo_debug: command not found
bash: __sdkman_echo_debug: command not found

Workaround

Installation of findutils in system solves problems

microdnf install findutils

System info

• OS - Oracle Linux Server release 8.10
• ImageID: 93f0c63e851885be509c5d83090d65ee4716b23ba7b9667a67a0866aa2546a98
• Shell and version - GNU bash, version 4.4.20(1)-release (x86_64-redhat-linux-gnu)
• The output of sdk version - does not work without workaround

SDKMAN!
script: 5.19.0
native: 0.7.4 (linux x86_64)

[marc0der]

Hi @bambuchaAdm, I'd be happy to accept a PR to remedy this. You can find the relevant code included in the installer script in our sdkman-hooks project over here.

[teras]

I have a similar problem with unzip:

⋊> ~ sdk install java 21.0.8-tem                                                                                15:40 

Downloading: java 21.0.8-tem

In progress...

############################################################################################################### 100.0%

Repackaging Java 21.0.8-tem...

Done repackaging...
/home/teras/.sdkman/src/sdkman-install.sh: line 165: unzip: command not found

Stop! The archive was corrupt and has been removed! Please try installing again.
⋊> ~  

I'll be happy to create a PR if you are interested.
Should it be the path that @marc0der provided? It is labeled "scala" and I am a bit confused.

[marc0der]

We definitely check for unzip during the installation process. Perhaps you accidentally uninstalled unzip, or else moved your SDKMAN installation to a new system?

[teras]

Actually I was expecting this. So, I installed unzip, uninstalled it again, and then run this command and again it failed.

Maybe, if I understood your question, is sdkman checking only during install? Shouldn't check every time it runs?
Like you said, for some twisted reason, I might have changed my computer configuration. And it's nothing more annoying after downloading a huge file from a crappy corporate internet connection, at the very end to fail (and delete the file and have to start all over again.

[marc0der]

You're right, we only do the check at installation time. In all these years we've never been asked to be defensive checking the underlying dependencies on every command issued.

My suggestion for now would be to simply install unzip and the problem should go away.

[teras]

Of course, we're developers and this kind of "issues" is beyond trivial for us. Having said that, I believe always commands should be defensive. Especially installers of any sort. Maybe the only reason that nobody complaint is because the problem was so trivial that nobody cared to complain about it.