Add sdkman_selfupdate_feature flag to disable selfupdate functionality for Homebrew #44
Conversation
|
I'd like to suggest that we first roll this out to the beta hooks, then later to the stable channel when we are about to do the final release. |
|
I'll add a few more tests. I also need to make sure that the |
app/views/selfupdate_beta.scala.txt
Outdated
| fi | ||
|
|
||
| # migrate deprecated sdkman_selfupdate_enable configuration | ||
| sed -i.bak -e 's/sdkman_selfupdate_enable/sdkman_auto_update/' "$sdkman_config_file" && rm "${sdkman_config_file}.bak" |
There was a problem hiding this comment.
Let's keep the .bak file around for traceability. Also, how about instead of just calling it .bak we give it a name like -2022-02-12.bak?
There was a problem hiding this comment.
I've switched to solution which is guaranteed to also work on more esoteric systems (like Solaris).
There was a problem hiding this comment.
Cool, also keep in mind that you can generate the date on the serverside because this is a play template.
helpermethod
force-pushed
the
homebrew-support
branch
from
95d87af to
1f5e586
Compare
|
@marc0der Added the timestamp by defining a template variable and squashed everything together 😄. |
|
Thanks @helpermethod! |
2 participants
Related to sdkman/sdkman-cli#1042.