better

Author: xadupre

onnx_diagnostic/torch_models/hghub/model_inputs.py

@@ -96,6 +96,7 @@ def get_untrained_model_with_inputs(
         assert (
             type(config) is not dict
         ), f"Unable to set dynamic_rope if the configuration is a dictionary\n{config}"
+        assert hasattr(config, "rope_scaling"), f"Missing 'rope_scaling' in\n{config}"
         config.rope_scaling = (
             {"rope_type": "dynamic", "factor": 10.0} if dynamic_rope else None
         )

onnx_diagnostic/torch_models/test_helper.py

@@ -1069,15 +1069,16 @@ def call_torch_export_custom(
     assert (
         optimization in available
     ), f"unexpected value for optimization={optimization}, available={available}"
-    assert exporter in {
+    available = {
         "custom",
         "custom-strict",
-        "custom-strict-dec",
+        "custom-strict-default",
         "custom-strict-all",
         "custom-nostrict",
-        "custom-nostrict-dec",
+        "custom-nostrict-default",
         "custom-nostrict-all",
-    }, f"Unexpected value for exporter={exporter!r}"
+    }
+    assert exporter in available, f"Unexpected value for exporter={exporter!r} in {available}"
     assert "model" in data, f"model is missing from data: {sorted(data)}"
     assert "inputs_export" in data, f"inputs_export is missing from data: {sorted(data)}"
     summary: Dict[str, Union[str, int, float]] = {}
@@ -1109,7 +1110,7 @@ def call_torch_export_custom(
     export_options = ExportOptions(
         strict=strict,
         decomposition_table=(
-            "dec" if "-dec" in exporter else ("all" if "-all" in exporter else None)
+            "default" if "-default" in exporter else ("all" if "-all" in exporter else None)
         ),
     )
     options = OptimizationOptions(patterns=optimization) if optimization else None