last fix for modelbuilder

Author: xadupre

_unittests/ut_torch_models/test_validate_whole_models.py

@@ -195,17 +195,18 @@ def test_k_filter_inputs(self):
     @ignore_warnings(FutureWarning)
     @requires_transformers("4.51")
     def test_l_validate_model_modelbuilder(self):
-        mid = "meta-llama/Llama-2-7b-hf"
+        mid = "microsoft/phi-2"
         summary, data = validate_model(
             mid,
             do_run=True,
             verbose=10,
             exporter="modelbuilder",
             dump_folder="dump_test/validate_model_modelbuilder",
+            patch=True,
         )
         self.assertIsInstance(summary, dict)
         self.assertIsInstance(data, dict)
-        self.assertLess(summary["disc_onnx_ort_run_abs"], 1e-2)
+        self.assertLess(summary["disc_onnx_ort_run_abs"], 3e-2)
         onnx_filename = data["onnx_filename"]
         self.assertExists(onnx_filename)
 

onnx_diagnostic/helpers/rt_helper.py

@@ -41,7 +41,7 @@ def make_feeds(
     """
     # NOTE: position_ids is a special case because ModelBuilder does not usually use it,
     # because it's fued into rotary embedding in GQA.
-    if isinstance(inputs, dict):
+    if is_modelbuilder and isinstance(inputs, dict):
         inputs.pop("position_ids", None)  # Ensure 'position_ids' absent before removing.
 
     flat = flatten_object(inputs, drop_keys=True)