Skip to content

Commit 9786c00

Browse files
committed
fix agg
1 parent fafb38a commit 9786c00

File tree

3 files changed

+312
-57
lines changed

3 files changed

+312
-57
lines changed

_unittests/ut_helpers/test_log_helper.py

Lines changed: 12 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -151,9 +151,17 @@ def test_cube_logs_view_agg(self):
151151
ignore_columns=["version_python"],
152152
)
153153
)
154-
self.assertEqual((2, 2), view.shape)
155-
self.assertEqual(["time_baseline", "time_latency"], list(view.columns))
156-
self.assertEqual([("export",), ("onnx-dynamo",)], list(view.index))
154+
self.assertEqual((4, 1), view.shape)
155+
self.assertEqual(["VALUE"], list(view.columns))
156+
self.assertEqual(
157+
[
158+
("export", "time_baseline"),
159+
("export", "time_latency"),
160+
("onnx-dynamo", "time_baseline"),
161+
("onnx-dynamo", "time_latency"),
162+
],
163+
list(view.index),
164+
)
157165

158166
@hide_stdout()
159167
def test_cube_logs_excel(self):
@@ -210,6 +218,7 @@ def test_cube_logs_performance(self):
210218
"agg-suite",
211219
"disc",
212220
"speedup",
221+
"counts",
213222
"time",
214223
"time_export",
215224
"err",

onnx_diagnostic/_command_lines_parser.py

Lines changed: 11 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -647,15 +647,16 @@ def get_parser_agg() -> ArgumentParser:
647647
parser.add_argument(
648648
"-k",
649649
"--keys",
650-
default="^version_.*,^model_.*,device,opt_patterns,suite,memory_peak,machine,exporter,dynamic,rtopt,dtype,device,architecture",
650+
default="^version_.*,^model_.*,device,opt_patterns,suite,memory_peak,"
651+
"machine,exporter,dynamic,rtopt,dtype,device,architecture",
651652
help="List of columns to consider as keys, "
652653
"multiple values are separated by `,`\n"
653654
"regular expressions are allowed",
654655
)
655656
parser.add_argument(
656657
"-w",
657658
"--values",
658-
default="^time_.*,^disc.*,^ERR_.*,CMD,^ITER.*",
659+
default="^time_.*,^disc.*,^ERR_.*,CMD,^ITER.*,^onnx_.*,^op_onnx_.*",
659660
help="List of columns to consider as values, "
660661
"multiple values are separated by `,`\n"
661662
"regular expressions are allowed",
@@ -666,12 +667,18 @@ def get_parser_agg() -> ArgumentParser:
666667
parser.add_argument(
667668
"-f",
668669
"--formula",
669-
default="speedup,bucket[speedup],ERR1",
670+
default="speedup,bucket[speedup],ERR1,n_models,n_eager,"
671+
"n_running,n_acc01,n_acc001,n_dynamic,n_pass,n_faster,"
672+
"n_faster2x,n_faster3x,n_faster4x,n_attention,"
673+
"peak_gpu_torch,peak_gpu_nvidia,n_control_flow,"
674+
"n_constant,n_shape,n_expand,"
675+
"n_function,n_initializer,n_scatter,time_export_unbiased",
670676
help="Columns to compute after the aggregation was done.",
671677
)
672678
parser.add_argument(
673679
"--views",
674-
default="agg-suite,disc,speedup,time,time_export,err,cmd,bucket-speedup,raw-short",
680+
default="agg-suite,disc,speedup,time,time_export,err,cmd,"
681+
"bucket-speedup,raw-short,counts",
675682
help="Views to add to the output files.",
676683
)
677684
parser.add_argument(

0 commit comments

Comments
 (0)