Skip to content

Commit b93cb03

Browse files
committed
Fix freeze pane, add more metrics
1 parent 37f70e0 commit b93cb03

File tree

1 file changed

+33
-13
lines changed

1 file changed

+33
-13
lines changed

onnx_diagnostic/helpers/log_helper.py

Lines changed: 33 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1167,7 +1167,7 @@ def to_excel(
11671167
df.to_excel(
11681168
writer,
11691169
sheet_name=name,
1170-
freeze_panes=(df.columns.nlevels + df.index.nlevels, df.index.nlevels),
1170+
freeze_panes=(df.columns.nlevels + 1, df.index.nlevels),
11711171
)
11721172
f_highlights[name] = tview.f_highlight
11731173
if tview.plots:
@@ -1222,15 +1222,15 @@ def to_excel(
12221222
writer,
12231223
sheet_name=name,
12241224
freeze_panes=(
1225-
sbs_raw.columns.nlevels + sbs_raw.index.nlevels,
1225+
sbs_raw.columns.nlevels + 1,
12261226
sbs_raw.index.nlevels,
12271227
),
12281228
)
12291229
sbs_agg.to_excel(
12301230
writer,
12311231
sheet_name=f"{name}-AGG",
12321232
freeze_panes=(
1233-
sbs_agg.columns.nlevels + sbs_agg.index.nlevels,
1233+
sbs_agg.columns.nlevels + 1,
12341234
sbs_agg.index.nlevels,
12351235
),
12361236
)
@@ -1456,9 +1456,7 @@ def _mkc(m, s):
14561456

14571457

14581458
class CubeLogsPerformance(CubeLogs):
1459-
"""
1460-
Processes logs coming from experiments.
1461-
"""
1459+
"""Processes logs coming from experiments."""
14621460

14631461
def __init__(
14641462
self,
@@ -1511,20 +1509,24 @@ def __init__(
15111509
"n_model_faster2x",
15121510
"n_model_faster3x",
15131511
"n_model_faster4x",
1512+
"n_model_faster5x",
15141513
"n_node_attention",
15151514
"n_node_attention23",
1516-
"n_node_rotary_embedding",
1517-
"n_node_rotary_embedding23",
1518-
"n_node_layer_normalization",
1519-
"n_node_layer_normalization23",
1515+
"n_node_causal_mask",
1516+
"n_node_constant",
15201517
"n_node_control_flow",
1521-
"n_node_scatter",
1518+
"n_node_expand",
15221519
"n_node_function",
15231520
"n_node_initializer",
15241521
"n_node_initializer_small",
1525-
"n_node_constant",
1522+
"n_node_layer_normalization",
1523+
"n_node_layer_normalization23",
1524+
"n_node_reshape",
1525+
"n_node_rotary_embedding",
1526+
"n_node_rotary_embedding23",
1527+
"n_node_scatter",
1528+
"n_node_sequence",
15261529
"n_node_shape",
1527-
"n_node_expand",
15281530
"onnx_n_nodes_no_cst",
15291531
"peak_gpu_torch",
15301532
"peak_gpu_nvidia",
@@ -1690,6 +1692,11 @@ def first_err(df: pandas.DataFrame) -> pandas.Series:
16901692
"time_latency",
16911693
gdf(df, "time_latency_eager") > gdf(df, "time_latency", np.inf) * 3.98,
16921694
),
1695+
n_model_faster5x=lambda df: gpreserve(
1696+
df,
1697+
"time_latency",
1698+
gdf(df, "time_latency_eager") > gdf(df, "time_latency", np.inf) * 4.98,
1699+
),
16931700
n_node_attention23=lambda df: gpreserve(
16941701
df, "time_latency_eager", gdf(df, "op_onnx__Attention")
16951702
),
@@ -1764,9 +1771,22 @@ def first_err(df: pandas.DataFrame) -> pandas.Series:
17641771
n_node_shape=lambda df: gpreserve(
17651772
df, "time_latency_eager", gdf(df, "op_onnx__Shape")
17661773
),
1774+
n_node_reshape=lambda df: gpreserve(
1775+
df, "time_latency_eager", gdf(df, "op_onnx__Reshape")
1776+
),
17671777
n_node_expand=lambda df: gpreserve(
17681778
df, "time_latency_eager", gdf(df, "op_onnx__Expand")
17691779
),
1780+
n_node_causal_mask=lambda df: gpreserve(
1781+
df,
1782+
"time_latency_eager",
1783+
gdf(df, "op_onnx__CausalMask", 0),
1784+
),
1785+
n_node_sequence=lambda df: gpreserve(
1786+
df,
1787+
"time_latency_eager",
1788+
gdf(df, "op_onnx__SequenceAt", 0) + gdf(df, "op_onnx__SplitToSequence", 0),
1789+
),
17701790
)
17711791
assert (
17721792
formula in lambdas

0 commit comments

Comments
 (0)