Patch for Phi3RotaryEmbedding (dynamic_rope_update) #128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xadupre
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #128 +/- ##
=======================================
Coverage 76.33% 76.33%
=======================================
Files 104 104
Lines 10744 10791 +47
=======================================
+ Hits 8201 8237 +36
- Misses 2543 2554 +11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
sdpython
changed the title
sdpython
approved these changes
Jun 6, 2025
titaiwangms
reviewed
Jun 6, 2025
| (lambda x, y: y.clone()), | ||
| [long_inv_freq, original_inv_freq], | ||
| ) | ||
| self.inv_freq = inv_freq |
Collaborator
There was a problem hiding this comment.
We don't need to register the buffer?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.