Use explicit ping function for AG device checks

Author: albireox

src/gort/devices/ag.py

@@ -10,12 +10,10 @@
 
 import asyncio
 
-from lvmopstools.utils import is_host_up
-
 from gort.devices.core import GortDevice, GortDeviceSet
 from gort.exceptions import GortDeviceError
 from gort.gort import Gort
-from gort.tools import run_lvmapi_task
+from gort.tools import ping_host, run_lvmapi_task
 
 
 __all__ = ["AG", "AGSet"]
@@ -135,11 +133,16 @@ async def check_camera(self, ping: bool = True, status: bool = True):
 
         if ping:
             for side, ip in self.ips.items():
+                name = f"{self.name}-{side}"
+
                 if ip is None:
                     continue
 
-                if not await is_host_up(ip):
-                    failed.add(side)
+                if not await ping_host(ip):
+                    self.write_to_log(f"AG {name} did not ping.", "warning")
+                    failed.add(name)
+                else:
+                    self.write_to_log(f"AG {name} pinged back.", "debug")
 
         if status:
             try:
@@ -151,8 +154,7 @@ async def check_camera(self, ping: bool = True, status: bool = True):
             return True
 
         raise GortDeviceError(
-            f"The following {self.name} AG cameras are not responding: "
-            f"{', '.join(failed)}."
+            f"The following AG cameras are not responding: {', '.join(failed)}."
         )
 
 

src/gort/tools.py

@@ -17,6 +17,7 @@
 import os
 import pathlib
 import re
+import subprocess
 import tempfile
 import warnings
 from contextlib import asynccontextmanager, contextmanager, suppress
@@ -104,6 +105,7 @@
     "try_or_pass",
     "record_overheads",
     "OverheadDict",
+    "ping_host",
 ]
 
 AnyPath = str | os.PathLike
@@ -1204,3 +1206,16 @@ def record_overheads(payload: Sequence[OverheadDict] | OverheadDict):
 
     table_name = config["services.database.tables.overheads"]
     insert_to_database(table_name, payload_dict)
+
+
+async def ping_host(host: str):
+    """Pings a host."""
+
+    cmd = await asyncio.create_subprocess_exec(
+        *["ping", "-c", "1", "-W", "5", host],
+        stdout=subprocess.PIPE,
+        stderr=subprocess.PIPE,
+    )
+
+    return_code = await cmd.wait()
+    return return_code == 0