Skip to content

Commit 15ac1e4

Browse files
committed
Use helper function for all the mos_target_num variants
1 parent 828479d commit 15ac1e4

File tree

1 file changed

+17
-7
lines changed

1 file changed

+17
-7
lines changed

python/sdss_access/path/path.py

Lines changed: 17 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1793,7 +1793,7 @@ def tilegrp(self, filetype, **kwargs):
17931793
return '{0}XX'.format(tileid)
17941794
return '{:0>4d}XX'.format(int(tileid) // 1000)
17951795

1796-
def mos_target_num(self, filetype, zp: Union[int, None] = None, prefix: str = "-", **kwargs):
1796+
def _mos_target_num_helper(self, filetype, zp: Union[int, None] = None, prefix: str = "-", **kwargs):
17971797
"""Returns the target filetype for a given MOS filetype
17981798
17991799
File species of the type ``mos_target_XXX`` can be used to retrieve
@@ -1834,26 +1834,36 @@ def mos_target_num(self, filetype, zp: Union[int, None] = None, prefix: str = "-
18341834

18351835
return ""
18361836

1837+
def mos_target_num(self, filetype, **kwargs):
1838+
"""Returns the target filetype for a given MOS filetype.
1839+
1840+
No zero-padding is applied to the number.
1841+
1842+
"""
1843+
1844+
return self._mos_target_num_helper(filetype, zp=None, **kwargs)
1845+
1846+
18371847
def mos_target_num2(self, filetype, **kwargs):
1838-
"""Returns the target filetype for a given MOS filetype
1848+
"""Returns the target filetype for a given MOS filetype.
18391849
18401850
Same as ``mos_target_num`` but zero-pads the number to 2 digits.
18411851
18421852
"""
18431853

1844-
return self.mos_target_num(filetype, zp=2, **kwargs)
1854+
return self._mos_target_num_helper(filetype, zp=2, **kwargs)
18451855

18461856
def mos_target_num3(self, filetype, **kwargs):
1847-
"""Returns the target filetype for a given MOS filetype
1857+
"""Returns the target filetype for a given MOS filetype.
18481858
18491859
Same as ``mos_target_num`` but zero-pads the number to 3 digits.
18501860
18511861
"""
18521862

1853-
return self.mos_target_num(filetype, zp=3, **kwargs)
1863+
return self._mos_target_num_helper(filetype, zp=3, **kwargs)
18541864

18551865
def mos_target_num_underscore(self, filetype, **kwargs):
1856-
"""Returns the target filetype for a given MOS filetype
1866+
"""Returns the target filetype for a given MOS filetype.
18571867
18581868
Same as ``mos_target_num`` but the number is prefixed with an underscore
18591869
instead of a dash.
@@ -1863,7 +1873,7 @@ def mos_target_num_underscore(self, filetype, **kwargs):
18631873
if "num" not in kwargs or kwargs["num"] is None:
18641874
kwargs["num"] = 1
18651875

1866-
return self.mos_target_num(filetype, prefix='_', **kwargs)
1876+
return self._mos_target_num_helper(filetype, zp=None, prefix='_', **kwargs)
18671877

18681878

18691879
class AccessError(Exception):

0 commit comments

Comments
 (0)