Skip to content

Commit a4a9969

Browse files
committed
Match SDV's handling of external minimum dependencies
1 parent 998596e commit a4a9969

File tree

2 files changed

+5
-1
lines changed

2 files changed

+5
-1
lines changed

.github/workflows/minimum.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,5 @@ jobs:
3131
run: |
3232
python -m pip install --upgrade pip
3333
python -m pip install invoke .[test]
34-
python -m pip install "scikit-learn<1.8.0"
3534
- name: Test with minimum versions
3635
run: invoke minimum

tasks.py

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,9 @@
2121
'<=': operator.le,
2222
'==': operator.eq,
2323
}
24+
EXTERNAL_DEPENDENCY_CAPS = {
25+
'scikit-learn': '1.8.0'
26+
}
2427

2528

2629
if not hasattr(inspect, 'getargspec'):
@@ -110,6 +113,8 @@ def install_minimum(c):
110113
if minimum_versions:
111114
install_deps = ' '.join(minimum_versions)
112115
c.run(f'python -m pip install {install_deps}')
116+
for dep, cap in EXTERNAL_DEPENDENCY_CAPS.items():
117+
c.run(f'python -m pip install "{dep}<{cap}"')
113118

114119

115120
@task

0 commit comments

Comments
 (0)