fix test 4

R-Palazzo · R-Palazzo · commit bc2feacc0495 · 2025-08-14T13:06:51.000+01:00
diff --git a/rdt/transformers/utils.py b/rdt/transformers/utils.py
@@ -180,6 +180,8 @@ def _fill_nan_with_none_series(data):
     dtype = data.dtype
     if isinstance(dtype, pd.CategoricalDtype):
         data = data.cat.add_categories([sentinel])
+        data = data.fillna(sentinel).replace({sentinel: None})
+        return pd.Series(pd.Categorical(data, categories=dtype.categories), index=data.index)
 
     return data.fillna(sentinel).replace({sentinel: None})
 
diff --git a/tests/unit/transformers/test_utils.py b/tests/unit/transformers/test_utils.py
@@ -184,9 +184,7 @@ def test__fill_nan_with_none_series():
     expected_result_categorical = pd.Series(
         pd.Categorical(['a', 'b', 'c', 'd', None], categories=['a', 'b', 'c', 'd'])
     )
-    pd.testing.assert_series_equal(
-        result_categorical, expected_result_categorical, check_dtype=False
-    )
+    pd.testing.assert_series_equal(result_categorical, expected_result_categorical)
 
 
 def test_fill_nan_with_none_series():

Original file line number	Diff line number	Diff line change
`@@ -184,9 +184,7 @@ def test__fill_nan_with_none_series():`
`184`	`184`	`expected_result_categorical = pd.Series(`
`185`	`185`	`pd.Categorical(['a', 'b', 'c', 'd', None], categories=['a', 'b', 'c', 'd'])`
`186`	`186`	`)`
`187`		`- pd.testing.assert_series_equal(`
`188`		`- result_categorical, expected_result_categorical, check_dtype=False`
`189`		`- )`
	`187`	`+ pd.testing.assert_series_equal(result_categorical, expected_result_categorical)`
`190`	`188`
`191`	`189`
`192`	`190`	`def test_fill_nan_with_none_series():`