test 4

Author: R-Palazzo

.github/workflows/run_benchmark_multi_table.yaml

@@ -33,12 +33,11 @@ jobs:
 
     - name: Run SDGym Benchmark
       env:
-        GCP_SERVICE_ACCOUNT_JSON: ${{ secrets.GCP_CREDENTIALS_JSON }}
-        SDV_ENTERPRISE_USERNAME: ${{ secrets.GCP_USERNAME }}
-        SDV_ENTERPRISE_LICENSE_KEY: ${{ secrets.GCP_LICENSE_KEY }}
+        GCP_SERVICE_ACCOUNT_JSON: ${{ secrets.GCP_SERVICE_ACCOUNT_JSON }}
+        SDV_ENTERPRISE_USERNAME: ${{ secrets.SDV_ENTERPRISE_USERNAME }}
+        SDV_ENTERPRISE_LICENSE_KEY: ${{ secrets.SDV_ENTERPRISE_LICENSE_KEY }}
         AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }}
         AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
-        AWS_DEFAULT_REGION: ${{ secrets.AWS_REGION }}
         SLACK_TOKEN: ${{ secrets.SLACK_TOKEN }}
       run: |
         export CREDENTIALS_FILEPATH=$(python -c "from sdgym._benchmark.credentials_utils import create_credentials_file; print(create_credentials_file())")

sdgym/_benchmark/credentials_utils.py

@@ -74,33 +74,24 @@ def sdv_install_cmd(credentials):
     )
 
 
-def create_credentials_file(filepath, credentials=None):
-    """Create a credentials file.
-
-    Args:
-        filepath (str): The path to the credentials file.
-        credentials (dict):
-            The credentials to write to the file. If None, credential will be defined
-            based on environment variables. Defaults to None.
-    """
-    if credentials is None:
-        gcp_json = os.getenv('GCP_SERVICE_ACCOUNT_JSON')
-
-        credentials = {
-            'aws': {
-                'aws_access_key_id': os.getenv('AWS_ACCESS_KEY_ID'),
-                'aws_secret_access_key': os.getenv('AWS_SECRET_ACCESS_KEY'),
-            },
-            'gcp': {
-                **json.loads(gcp_json),
-                'gcp_project': 'sdgym-337614',
-                'gcp_zone': 'us-central1-a',
-            },
-            'sdv': {
-                'username': os.getenv('SDV_ENTERPRISE_USERNAME'),
-                'license_key': os.getenv('SDV_ENTERPRISE_LICENSE_KEY'),
-            },
-        }
+def create_credentials_file():
+    """Create a credentials file."""
+    gcp_json = os.getenv('GCP_SERVICE_ACCOUNT_JSON')
+    credentials = {
+        'aws': {
+            'aws_access_key_id': os.getenv('AWS_ACCESS_KEY_ID'),
+            'aws_secret_access_key': os.getenv('AWS_SECRET_ACCESS_KEY'),
+        },
+        'gcp': {
+            **json.loads(gcp_json),
+            'gcp_project': 'sdgym-337614',
+            'gcp_zone': 'us-central1-a',
+        },
+        'sdv': {
+            'username': os.getenv('SDV_ENTERPRISE_USERNAME'),
+            'license_key': os.getenv('SDV_ENTERPRISE_LICENSE_KEY'),
+        },
+    }
 
     tmp_file = NamedTemporaryFile(mode='w+', delete=False, suffix='.json')
     json.dump(credentials, tmp_file)