Skip to content

Commit 2849fa5

Browse files
committed
add region name 2
1 parent ebf6d0d commit 2849fa5

File tree

3 files changed

+12
-2
lines changed

3 files changed

+12
-2
lines changed

sdgym/s3.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -209,6 +209,7 @@ def _get_s3_client(output_destination, aws_access_key_id=None, aws_secret_access
209209
's3',
210210
aws_access_key_id=aws_access_key_id,
211211
aws_secret_access_key=aws_secret_access_key,
212+
region_name=S3_REGION,
212213
)
213214
else:
214215
s3_client = boto3.client('s3')

tests/unit/test_datasets.py

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@
1414
get_dataset_paths,
1515
load_dataset,
1616
)
17+
from sdgym.s3 import S3_REGION
1718

1819

1920
class AnyConfigWith:
@@ -136,7 +137,10 @@ def test__download_dataset_private_bucket(boto3_mock, tmpdir):
136137

137138
# asserts
138139
boto3_mock.client.assert_called_once_with(
139-
's3', aws_access_key_id=aws_access_key_id, aws_secret_access_key=aws_secret_access_key
140+
's3',
141+
aws_access_key_id=aws_access_key_id,
142+
aws_secret_access_key=aws_secret_access_key,
143+
region_name=S3_REGION,
140144
)
141145
s3_mock.get_object.assert_called_once_with(
142146
Bucket='my_bucket', Key=f'{modality.upper()}/{dataset}.zip'

tests/unit/test_s3.py

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@
99
from botocore.exceptions import NoCredentialsError
1010

1111
from sdgym.s3 import (
12+
S3_REGION,
1213
_get_s3_client,
1314
_upload_dataframe_to_s3,
1415
_upload_pickle_to_s3,
@@ -178,7 +179,10 @@ def test_write_file_s3(boto3_mock):
178179

179180
# asserts
180181
boto3_mock.client.assert_called_once_with(
181-
's3', aws_access_key_id=aws_access_key_id, aws_secret_access_key=aws_secret_access_key
182+
's3',
183+
aws_access_key_id=aws_access_key_id,
184+
aws_secret_access_key=aws_secret_access_key,
185+
region_name=S3_REGION,
182186
)
183187
s3_mock.put_object.assert_called_once_with(
184188
Bucket=bucket_name,
@@ -307,6 +311,7 @@ def test__get_s3_client_with_credentials(mock_boto_client):
307311
's3',
308312
aws_access_key_id=aws_access_key_id,
309313
aws_secret_access_key=aws_secret_access_key,
314+
region_name=S3_REGION,
310315
)
311316
mock_s3_client.head_bucket.assert_called_once_with(Bucket='my-bucket')
312317

0 commit comments

Comments
 (0)