fix benchmark

Author: R-Palazzo

sdgym/benchmark.py

@@ -1191,15 +1191,17 @@ def _validate_aws_inputs(output_destination, aws_access_key_id, aws_secret_acces
     if not bucket_name:
         raise ValueError(f'Invalid S3 URL: {output_destination}')
 
+    config = Config(connect_timeout=30, read_timeout=300)
     if aws_access_key_id and aws_secret_access_key:
         s3_client = boto3.client(
             's3',
             aws_access_key_id=aws_access_key_id,
             aws_secret_access_key=aws_secret_access_key,
+            config=config,
         )
     else:
         # No credentials provided — rely on default session
-        s3_client = boto3.client('s3')
+        s3_client = boto3.client('s3', config=config)
 
     s3_client.head_bucket(Bucket=bucket_name)
     if not _check_write_permissions(s3_client, bucket_name):
@@ -1425,14 +1427,12 @@ def benchmark_single_table_aws(
         pandas.DataFrame:
             A table containing one row per synthesizer + dataset + metric.
     """
-    config = Config(connect_timeout=30, read_timeout=300)
     s3_client = _validate_output_destination(
         output_destination,
         aws_keys={
             'aws_access_key_id': aws_access_key_id,
             'aws_secret_access_key': aws_secret_access_key,
         },
-        config=config,
     )
     job_args_list = _generate_job_args_list(
         limit_dataset_size=limit_dataset_size,

tests/unit/test_benchmark.py

@@ -542,9 +542,12 @@ def test_setup_output_destination_aws(mock_get_run_id_increment):
 
 @patch('sdgym.benchmark.boto3.client')
 @patch('sdgym.benchmark._check_write_permissions')
-def test_validate_aws_inputs_valid(mock_check_write_permissions, mock_boto3_client):
+@patch('sdgym.benchmark.Config')
+def test_validate_aws_inputs_valid(mock_config, mock_check_write_permissions, mock_boto3_client):
     """Test `_validate_aws_inputs` with valid inputs and credentials."""
     # Setup
+    config_mock = Mock()
+    mock_config.return_value = config_mock
     valid_url = 's3://my-bucket/some/path'
     s3_client_mock = Mock()
     mock_boto3_client.return_value = s3_client_mock
@@ -557,7 +560,7 @@ def test_validate_aws_inputs_valid(mock_check_write_permissions, mock_boto3_clie
 
     # Assert
     mock_boto3_client.assert_called_once_with(
-        's3', aws_access_key_id='AKIA...', aws_secret_access_key='SECRET'
+        's3', aws_access_key_id='AKIA...', aws_secret_access_key='SECRET', config=config_mock
     )
     s3_client_mock.head_bucket.assert_called_once_with(Bucket='my-bucket')
     mock_check_write_permissions.assert_called_once_with(s3_client_mock, 'my-bucket')