Skip to content

Commit 5b162ff

Browse files
committed
fix tests
1 parent 562d2d1 commit 5b162ff

File tree

4 files changed

+22
-5
lines changed

4 files changed

+22
-5
lines changed

.github/workflows/run_benchmark_multi_table.yaml

Lines changed: 11 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,12 +28,21 @@ jobs:
2828
source venv/bin/activate
2929
3030
python -m pip install --upgrade pip
31-
python -m pip install sdv-enterprise --index-url "https://${USERNAME}:${LICENSE_KEY}@pypi.datacebo.com"
31+
python -m pip install sdv-installer
32+
python -c "
33+
from sdv_installer.installation.installer import install_packages
34+
install_packages(
35+
username='${USERNAME}',
36+
license_key='${LICENSE_KEY}',
37+
package='sdv-enterprise',
38+
)
39+
"
3240
python -m pip install "sdgym[all] @ git+https://github.com/sdv-dev/SDGym.git@issue-516-add-workflows"
3341
3442
echo "VIRTUAL_ENV=$(pwd)/venv" >> $GITHUB_ENV
3543
echo "$(pwd)/venv/bin" >> $GITHUB_PATH
36-
44+
- name: Stop workflow after dependency install (temporary)
45+
run: exit 0
3746
- name: Run SDGym Benchmark
3847
env:
3948
GCP_SERVICE_ACCOUNT_JSON: ${{ secrets.GCP_SERVICE_ACCOUNT_JSON }}

.github/workflows/run_benchmark_single_table.yml

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,15 @@ jobs:
2828
source venv/bin/activate
2929
3030
python -m pip install --upgrade pip
31-
python -m pip install sdv-enterprise --index-url "https://${USERNAME}:${LICENSE_KEY}@pypi.datacebo.com"
31+
python -m pip install sdv-installer
32+
python -c "
33+
from sdv_installer.installation.installer import install_packages
34+
install_packages(
35+
username='${USERNAME}',
36+
license_key='${LICENSE_KEY}',
37+
package='sdv-enterprise',
38+
)
39+
"
3240
python -m pip install "sdgym[all] @ git+https://github.com/sdv-dev/SDGym.git@issue-516-add-workflows"
3341
3442
echo "VIRTUAL_ENV=$(pwd)/venv" >> $GITHUB_ENV

sdgym/run_benchmark/utils.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -114,7 +114,7 @@ def post_benchmark_launch_message(date_str, compute_service='AWS', modality='sin
114114

115115
def post_benchmark_uploaded_message(folder_name, commit_url=None, modality='single_table'):
116116
"""Post benchmark uploaded message to sdv-alerts slack channel."""
117-
channel = SLACK_CHANNEL
117+
channel = DEBUG_SLACK_CHANNEL
118118
bucket, prefix = parse_s3_path(OUTPUT_DESTINATION_AWS)
119119
modality_text = modality.replace('_', '-')
120120
url_link = get_s3_console_link(bucket, quote_plus(f'{prefix}{modality}/SDGym Monthly Run.xlsx'))

tests/unit/run_benchmark/test_utils.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -107,7 +107,7 @@ def test_post_benchmark_launch_message(
107107
mock_get_s3_console_link.assert_called_once_with(
108108
'my-bucket', f'my-prefix/single_table/{folder_name}/'
109109
)
110-
mock_post_slack_message.assert_called_once_with('sdv-alerts-debug', expected_body)
110+
mock_post_slack_message.assert_called_once_with('sdv-alerts', expected_body)
111111

112112

113113
@patch('sdgym.run_benchmark.utils.post_slack_message')

0 commit comments

Comments
 (0)