update slack message

Author: R-Palazzo

sdgym/run_benchmark/run_benchmark.py

@@ -57,7 +57,7 @@ def main():
         )
 
     append_benchmark_run(aws_access_key_id, aws_secret_access_key, date_str)
-    post_benchmark_launch_message()
+    post_benchmark_launch_message(date_str)
 
 
 if __name__ == '__main__':

sdgym/run_benchmark/utils.py

@@ -15,11 +15,14 @@
 SYNTHESIZERS_SPLIT = [
     ['UniformSynthesizer', 'ColumnSynthesizer', 'GaussianCopulaSynthesizer'],
     ['TVAESynthesizer'],
-    ['CopulaGANSynthesizer'],
-    ['CTGANSynthesizer'],
-    ['RealTabFormerSynthesizer'],
 ]
 
+"""
+['CopulaGANSynthesizer'],
+['CTGANSynthesizer'],
+['RealTabFormerSynthesizer'],
+"""
+
 
 def get_result_folder_name(date_str):
     """Get the result folder name based on the date string."""
@@ -49,18 +52,20 @@ def post_slack_message(channel, text):
     client.chat_postMessage(channel=channel, text=text)
 
 
-def post_benchmark_launch_message():
+def post_benchmark_launch_message(date_str):
     """Post a message to the SDV Alerts Slack channel when the benchmark is launched."""
     channel = DEBUG_SLACK_CHANNEL
-    body = 'SDGym benchmark has been launched! Results will be available soon.'
+    body = '🏃 SDGym benchmark has been launched! EC2 Instances are running. '
+    body += 'Intermediate results can be found '
+    body += f'<{OUTPUT_DESTINATION_AWS}{get_result_folder_name(date_str)} |here>.\n'
     post_slack_message(channel, body)
 
 
 def post_run_summary(folder_name):
     """Post run summary to sdv-alerts slack channel."""
     channel = DEBUG_SLACK_CHANNEL
     body = ''
-    body += f'SDGym benchmark results for {folder_name} are available!\n'
+    body += f'🤸🏻‍♀️ SDGym benchmark results for {folder_name} are available!🏋️‍♀️ \n'
     body += (
         f'Check the results <{OUTPUT_DESTINATION_AWS}{folder_name}/{folder_name}_summary'
         '.csv|here>.\n'

tests/unit/run_benchmark/test_run_benchmark.py

@@ -5,7 +5,7 @@
 from botocore.exceptions import ClientError
 
 from sdgym.run_benchmark.run_benchmark import append_benchmark_run, main
-from sdgym.run_benchmark.utils import OUTPUT_DESTINATION_AWS, SYNTHESIZERS
+from sdgym.run_benchmark.utils import OUTPUT_DESTINATION_AWS, SYNTHESIZERS_SPLIT
 
 
 @patch('sdgym.run_benchmark.run_benchmark.get_s3_client')
@@ -103,7 +103,13 @@ def test_append_benchmark_run_new_file(
 @patch('sdgym.run_benchmark.run_benchmark.benchmark_single_table_aws')
 @patch('sdgym.run_benchmark.run_benchmark.os.getenv')
 @patch('sdgym.run_benchmark.run_benchmark.append_benchmark_run')
-def test_main(mock_append_benchmark_run, mock_getenv, mock_benchmark_single_table_aws):
+@patch('sdgym.run_benchmark.run_benchmark.post_benchmark_launch_message')
+def test_main(
+    mock_post_benchmark_launch_message,
+    mock_append_benchmark_run,
+    mock_getenv,
+    mock_benchmark_single_table_aws,
+):
     """Test the `main` method."""
     # Setup
     mock_getenv.side_effect = ['my_access_key', 'my_secret_key']
@@ -116,13 +122,14 @@ def test_main(mock_append_benchmark_run, mock_getenv, mock_benchmark_single_tabl
     mock_getenv.assert_any_call('AWS_ACCESS_KEY_ID')
     mock_getenv.assert_any_call('AWS_SECRET_ACCESS_KEY')
     expected_calls = []
-    for synthesizer in SYNTHESIZERS:
+    for synthesizer in SYNTHESIZERS_SPLIT:
         expected_calls.append(
             call(
                 output_destination=OUTPUT_DESTINATION_AWS,
                 aws_access_key_id='my_access_key',
                 aws_secret_access_key='my_secret_key',
-                synthesizers=[synthesizer],
+                synthesizers=synthesizer,
+                sdv_datasets=['expedia_hotel_logs', 'fake_companies'],
                 compute_privacy_score=False,
             )
         )
@@ -133,3 +140,4 @@ def test_main(mock_append_benchmark_run, mock_getenv, mock_benchmark_single_tabl
         'my_secret_key',
         date,
     )
+    mock_post_benchmark_launch_message.assert_called_once_with(date)