wip

Author: gsheni

sdv/metadata/multi_table.py

@@ -276,6 +276,7 @@ def _get_foreign_keys(self, parent_table_name, child_table_name):
         return foreign_keys
 
     def _get_all_foreign_keys(self, table_name):
+
         foreign_keys = []
         for relation in self.relationships:
             if table_name == relation['child_table_name']:

sdv/multi_table/base.py

@@ -468,9 +468,19 @@ def _validate_table_name(self, table_name):
     def _assign_table_transformers(self, synthesizer, table_name, table_data):
         """Update the ``synthesizer`` to ignore the foreign keys while preprocessing the data."""
         synthesizer.auto_assign_transformers(table_data)
-        foreign_key_columns = self.metadata._get_all_foreign_keys(table_name)
-        column_name_to_transformers = {column_name: None for column_name in foreign_key_columns}
-        print(column_name_to_transformers)
+
+        # foreign_key_columns = self.metadata._get_all_foreign_keys(table_name)
+        # column_name_to_transformers = {column_name: None for column_name in foreign_key_columns}
+
+        column_name_to_transformers = {}
+        primary_key = self.metadata.tables[table_name].primary_key
+        for relation in self.metadata.relationships:
+            column_name = deepcopy(relation['child_foreign_key'])
+            if (
+                relation['child_table_name'] == table_name
+                and relation['child_foreign_key'] != primary_key
+            ):
+                column_name_to_transformers[column_name] = None
         synthesizer.update_transformers(column_name_to_transformers)
 
     def auto_assign_transformers(self, data):

sdv/single_table/base.py

@@ -247,7 +247,6 @@ def _validate_transformers(self, column_name_to_transformer):
         for column, transformer in column_name_to_transformer.items():
             if transformer is None:
                 continue
-
             if column in keys and not transformer.is_generator():
                 raise SynthesizerInputError(
                     f"Column '{column}' is a key. It cannot be preprocessed using "

tests/integration/multi_table/test_hma.py

@@ -2903,6 +2903,7 @@ def data_metadata_1_to_1():
     metadata = Metadata.load_from_dict(metadata_dict)
     metadata.validate()
     metadata.validate_data(data)
+    metadata.remove_primary_key('rooms')
     return data, metadata
 
 
@@ -2917,3 +2918,7 @@ def test_hma_1_to_1(data_metadata_1_to_1):
 
     # Assert
     assert synthetic_data['guests']['guest_email'].equals(synthetic_data['guests']['guest_email'])
+
+
+def test_hma_1_to_1_or_0(data_metadata_1_to_1):
+    pass