Skip to content

Commit fd2386f

Browse files
authored
Merge branch 'main' into issue-2708-missing_values_proportion-invalid-key
2 parents 18194a0 + f7f4345 commit fd2386f

File tree

5 files changed

+10
-8
lines changed

5 files changed

+10
-8
lines changed

pyproject.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ dependencies = [
3838
'copulas>=0.12.1',
3939
'ctgan>=0.11.0',
4040
'deepecho>=0.7.0',
41-
'rdt>=1.17.0',
41+
'rdt>=1.18.2',
4242
'sdmetrics>=0.21.0',
4343
'platformdirs>=4.0',
4444
'pyyaml>=6.0.1',

sdv/single_table/_dayz_utils.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -42,8 +42,8 @@ def detect_column_parameters(data, metadata, table_name):
4242
if sdtype == 'numerical':
4343
column_parameters[column_name] = {
4444
'num_decimal_digits': learn_rounding_digits(data[column_name]),
45-
'min_value': data[column_name].min().item(),
46-
'max_value': data[column_name].max().item(),
45+
'min_value': data[column_name].min(),
46+
'max_value': data[column_name].max(),
4747
}
4848
elif sdtype == 'datetime':
4949
datetime_format = column_metadata.get('datetime_format', None)
@@ -63,12 +63,12 @@ def detect_column_parameters(data, metadata, table_name):
6363
'start_timestamp': start_timestamp,
6464
'end_timestamp': end_timestamp,
6565
}
66-
elif sdtype in ['categorical', 'boolean']:
66+
elif sdtype == 'categorical':
6767
column_parameters[column_name] = {
6868
'category_values': data[column_name].dropna().unique().tolist()
6969
}
7070

71-
column_parameters[column_name]['missing_values_proportion'] = (
71+
column_parameters[column_name]['missing_values_proportion'] = float(
7272
data[column_name].isna().mean()
7373
)
7474

tasks.py

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,9 @@
1313
from packaging.version import Version
1414

1515
COMPARISONS = {'>=': operator.ge, '>': operator.gt, '<': operator.lt, '<=': operator.le}
16-
16+
EXTERNAL_DEPENDENCY_CAPS = {
17+
'torch': '2.9.0'
18+
}
1719

1820
if not hasattr(inspect, 'getargspec'):
1921
inspect.getargspec = inspect.getfullargspec
@@ -86,6 +88,8 @@ def install_minimum(c):
8688
if minimum_versions:
8789
install_deps = ' '.join(minimum_versions)
8890
c.run(f'python -m pip install {install_deps}')
91+
for dep, cap in EXTERNAL_DEPENDENCY_CAPS.items():
92+
c.run(f'python -m pip install "{dep}<{cap}"')
8993

9094

9195
@task

tests/integration/multi_table/test_dayz.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@ def test_create_parameters_end_to_end(self):
2424
'guest_email': {'missing_values_proportion': 0.0},
2525
'hotel_id': {'missing_values_proportion': 0.0},
2626
'has_rewards': {
27-
'category_values': [False, True],
2827
'missing_values_proportion': 0.0,
2928
},
3029
'room_type': {

tests/integration/single_table/test_dayz.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,6 @@ def test_create_parameters_end_to_end(self):
2323
'columns': {
2424
'guest_email': {'missing_values_proportion': 0.0},
2525
'has_rewards': {
26-
'category_values': [False, True],
2726
'missing_values_proportion': 0.0,
2827
},
2928
'room_type': {

0 commit comments

Comments
 (0)