Migrate devices.get, add error handling assertion

Author: codetheweb

seamapi/devices.py

@@ -129,14 +129,12 @@ def get(
             params["device_id"] = to_device_id(device)
         if name:
             params["name"] = name
-        res = requests.get(
-            f"{self.seam.api_url}/devices/get",
-            headers={"Authorization": f"Bearer {self.seam.api_key}"},
-            params=params,
+        res = self.seam.make_request(
+            "GET",
+            "/devices/get",
+            params=params
         )
-        if not res.ok:
-            raise Exception(res.text)
-        json_device = res.json()["device"]
+        json_device = res["device"]
         return Device.from_dict(json_device)
 
     def update(
@@ -178,7 +176,7 @@ def update(
             "properties": properties,
             "location": location,
         }
-        
+
         res = requests.post(
             f"{self.seam.api_url}/devices/update",
             headers={"Authorization": f"Bearer {self.seam.api_key}"},
@@ -188,7 +186,7 @@ def update(
             raise Exception(res.text)
 
         return True
-    
+
     def delete(self, device: Union[DeviceId, Device]) -> bool:
         """Deletes a device.
 
@@ -219,4 +217,4 @@ def delete(self, device: Union[DeviceId, Device]) -> bool:
         if not res.ok:
             raise Exception(res.text)
 
-        return None
+        return None

tests/devices/test_devices.py

@@ -1,4 +1,5 @@
 from seamapi import Seam
+from seamapi.types import SeamAPIException
 from tests.fixtures.run_august_factory import run_august_factory
 from seamapi.utils.deep_attr_dict import DeepAttrDict
 
@@ -33,4 +34,13 @@ def test_devices(seam: Seam):
     assert some_updated_lock.properties.name == "Updated lock"
 
     seam.devices.delete(device=(some_updated_lock))
-    assert len(seam.devices.list()) == len(devices) - 1
+    assert len(seam.devices.list()) == len(devices) - 1
+
+    # Test custom exception
+    try:
+        seam.devices.get(name="foo")
+        assert False
+    except SeamAPIException as error:
+        assert error.status_code == 404
+        assert type(error.request_id) == str
+        assert error.metadata["type"] == "device_not_found"