Pass message from API directly

Author: kadiryazici

src/lib/ui/thermostat/ClimatePreset.tsx

@@ -1,3 +1,4 @@
+import type { SeamHttpApiError } from '@seamapi/http/connect'
 import classNames from 'classnames'
 import {
   type HTMLAttributes,
@@ -70,6 +71,18 @@ interface PresetFormProps {
   withKeyField?: boolean
 }
 
+function useErrorMessage(isError: boolean, error: SeamHttpApiError | null): string {
+  return useMemo(() => {
+    if (!isError) return ''
+
+    if (error?.message != null) {
+      return error.message
+    }
+
+    return t.unknownErrorOccured
+  }, [error, isError])
+}
+
 function PresetForm(props: PresetFormProps): JSX.Element {
   const {
     defaultValues,
@@ -266,28 +279,11 @@ interface CreateFormProps {
   onComplete: () => void
 }
 
-const CreateClimatePresetErrorCodes = {
-  DeviceNotFound: 'device_not_found',
-  ClimatePresetExists: 'climate_preset_exists',
-}
-
 function CreateForm({ device, onComplete }: CreateFormProps): JSX.Element {
   const { mutate, isError, error, isPending } =
     useCreateThermostatClimatePreset()
 
-  const errorMessage = useMemo(() => {
-    if (!isError) return ''
-
-    if (error?.code === CreateClimatePresetErrorCodes.ClimatePresetExists) {
-      return t.keyAlreadyExists
-    }
-
-    if (error?.code === CreateClimatePresetErrorCodes.DeviceNotFound) {
-      return t.deviceNotFound
-    }
-
-    return t.unknownErrorOccured
-  }, [error, isError])
+  const errorMessage = useErrorMessage(isError, error)
 
   const onSubmit = useCallback(
     (values: PresetFormProps['defaultValues']) => {
@@ -341,10 +337,6 @@ interface UpdateFormProps {
   onComplete: () => void
   preset: ThermostatClimatePreset
 }
-const UpdateClimatePresetErrorCodes = {
-  DeviceNotFound: 'device_not_found',
-  ClimatePresetNotFound: 'climate_preset_not_found',
-}
 
 function UpdateForm({
   device,
@@ -386,20 +378,8 @@ function UpdateForm({
     [device, mutate, onComplete]
   )
 
-  const errorMessage = useMemo(() => {
-    if (!isError) return ''
-
-    if (error?.code === UpdateClimatePresetErrorCodes.ClimatePresetNotFound) {
-      return t.climatePresetNotFound
-    }
-
-    if (error?.code === UpdateClimatePresetErrorCodes.DeviceNotFound) {
-      return t.deviceNotFound
-    }
-
-    return t.unknownErrorOccured
-  }, [error, isError])
-
+  const errorMessage = useErrorMessage(isError, error);
+  
   return (
     <>
       <Snackbar
@@ -422,8 +402,6 @@ function UpdateForm({
 const t = {
   keyAlreadyExists: 'Climate Preset with this key already exists.',
   keyCannotContainSpaces: 'Climate Preset key cannot contain spaces.',
-  climatePresetNotFound: 'Climate Preset not found.',
-  deviceNotFound: 'Device not found.',
   nameField: 'Display Name (Optional)',
   fanModeField: 'Fan Mode',
   hvacModeField: 'HVAC Mode',

src/lib/ui/thermostat/ClimatePresets.tsx

@@ -30,12 +30,6 @@ interface ClimatePresetsManagement {
 
 const CreateNewPresetSymbol = Symbol('CreateNewPreset')
 
-const DeleteClimatePresetErrorCodes = {
-  ClimatePresetNotFound: 'climate_preset_not_found',
-  DeviceNotFound: 'device_not_found',
-  ClimatePresetIsScheduled: 'climate_preset_is_scheduled',
-}
-
 export function ClimatePresets(props: ClimatePresetsManagement): JSX.Element {
   const { device, onBack } = props
 
@@ -54,18 +48,8 @@ export function ClimatePresets(props: ClimatePresetsManagement): JSX.Element {
   const errorMessage = useMemo(() => {
     if (!isError) return ''
 
-    if (error?.code === DeleteClimatePresetErrorCodes.ClimatePresetNotFound) {
-      return t.climatePresetNotFound
-    }
-
-    if (error?.code === DeleteClimatePresetErrorCodes.DeviceNotFound) {
-      return t.deviceNotFound
-    }
-
-    if (
-      error?.code === DeleteClimatePresetErrorCodes.ClimatePresetIsScheduled
-    ) {
-      return t.climatePresetIsScheduled
+    if(error?.message != null) {
+      return error.message
     }
 
     return t.unknownErrorOccured
@@ -272,7 +256,4 @@ const t = {
   edit: 'Edit',
   unknownErrorOccured: 'An unknown error occurred.',
   climatePresetNotFound: 'Climate Preset not found.',
-  deviceNotFound: 'Device not found.',
-  climatePresetIsScheduled:
-    'The climate preset has upcoming schedules and cannot be deleted.',
 }