feat: Add disableClimateSettingSchedules prop (#597)

xplato · web-flow · commit 5ed4f0763cc4 · 2024-03-06T12:33:07.000-07:00
* feat: Add `disableScheduledClimates` prop

* Add to `props`

* Better `props` typing

* Add everywhere else

* Add to element

* Remove default specifier on all internal components

* Rename prop to `disableClimateSettingSchedules`

* Add default back to `ThermostatDeviceDetails` to avoid linter issue on
nullable bool
diff --git a/src/lib/element.tsx b/src/lib/element.tsx
@@ -46,6 +46,7 @@ const commonProps: R2wcProps<CommonProps> = {
   disableEditAccessCode: 'boolean',
   disableDeleteAccessCode: 'boolean',
   disableResourceIds: 'boolean',
+  disableClimateSettingSchedules: 'boolean',
   onBack: 'object',
   className: 'string',
 }
diff --git a/src/lib/seam/components/AccessCodeDetails/AccessCodeDetails.tsx b/src/lib/seam/components/AccessCodeDetails/AccessCodeDetails.tsx
@@ -43,6 +43,7 @@ export function AccessCodeDetails({
   disableLockUnlock = false,
   disableDeleteAccessCode = false,
   disableResourceIds = false,
+  disableClimateSettingSchedules,
   onBack,
   className,
 }: AccessCodeDetailsProps): JSX.Element | null {
@@ -69,6 +70,7 @@ export function AccessCodeDetails({
         disableEditAccessCode={disableEditAccessCode}
         disableDeleteAccessCode={disableDeleteAccessCode}
         disableResourceIds={disableResourceIds}
+        disableClimateSettingSchedules={disableClimateSettingSchedules}
         onBack={() => {
           selectDevice(null)
         }}
diff --git a/src/lib/seam/components/AccessCodeTable/AccessCodeTable.tsx b/src/lib/seam/components/AccessCodeTable/AccessCodeTable.tsx
@@ -84,6 +84,7 @@ export function AccessCodeTable({
   disableLockUnlock = false,
   disableDeleteAccessCode = false,
   disableResourceIds = false,
+  disableClimateSettingSchedules,
 }: AccessCodeTableProps): JSX.Element {
   useComponentTelemetry('AccessCodeTable')
 
@@ -147,6 +148,7 @@ export function AccessCodeTable({
         disableEditAccessCode={disableEditAccessCode}
         disableDeleteAccessCode={disableDeleteAccessCode}
         disableResourceIds={disableResourceIds}
+        disableClimateSettingSchedules={disableClimateSettingSchedules}
         onBack={() => {
           setSelectedEditAccessCodeId(null)
         }}
@@ -182,6 +184,7 @@ export function AccessCodeTable({
           disableEditAccessCode={disableEditAccessCode}
           disableDeleteAccessCode={disableDeleteAccessCode}
           disableResourceIds={disableResourceIds}
+          disableClimateSettingSchedules={disableClimateSettingSchedules}
           onBack={() => {
             setSelectedViewAccessCodeId(null)
           }}
@@ -202,6 +205,7 @@ export function AccessCodeTable({
         disableEditAccessCode={disableEditAccessCode}
         disableDeleteAccessCode={disableDeleteAccessCode}
         disableResourceIds={disableResourceIds}
+        disableClimateSettingSchedules={disableClimateSettingSchedules}
         onBack={toggleAddAccessCodeForm}
         className={className}
         onSuccess={() => {
diff --git a/src/lib/seam/components/ClimateSettingScheduleDetails/ClimateSettingScheduleDetails.tsx b/src/lib/seam/components/ClimateSettingScheduleDetails/ClimateSettingScheduleDetails.tsx
@@ -38,6 +38,7 @@ export function ClimateSettingScheduleDetails({
   disableCreateAccessCode,
   disableEditAccessCode,
   disableResourceIds = false,
+  disableClimateSettingSchedules,
 }: ClimateSettingScheduleDetailsProps): JSX.Element | null {
   useComponentTelemetry('ClimateSettingScheduleDetails')
 
@@ -65,6 +66,7 @@ export function ClimateSettingScheduleDetails({
         disableEditAccessCode={disableEditAccessCode}
         disableDeleteAccessCode={disableDeleteAccessCode}
         disableResourceIds={disableResourceIds}
+        disableClimateSettingSchedules={disableClimateSettingSchedules}
         onBack={() => {
           selectDevice(null)
         }}
diff --git a/src/lib/seam/components/ClimateSettingScheduleTable/ClimateSettingScheduleTable.tsx b/src/lib/seam/components/ClimateSettingScheduleTable/ClimateSettingScheduleTable.tsx
@@ -72,6 +72,7 @@ export function ClimateSettingScheduleTable({
   disableCreateAccessCode,
   disableEditAccessCode,
   disableResourceIds = false,
+  disableClimateSettingSchedules,
 }: ClimateSettingScheduleTableProps): JSX.Element {
   useComponentTelemetry('ClimateSettingScheduleTable')
 
@@ -125,6 +126,7 @@ export function ClimateSettingScheduleTable({
         disableEditAccessCode={disableEditAccessCode}
         disableDeleteAccessCode={disableDeleteAccessCode}
         disableResourceIds={disableResourceIds}
+        disableClimateSettingSchedules={disableClimateSettingSchedules}
         onBack={() => {
           setSelectedViewClimateSettingScheduleId(null)
         }}
diff --git a/src/lib/seam/components/DeviceDetails/DeviceDetails.tsx b/src/lib/seam/components/DeviceDetails/DeviceDetails.tsx
@@ -23,6 +23,7 @@ export function DeviceDetails({
   disableResourceIds = false,
   disableCreateAccessCode = false,
   disableEditAccessCode = false,
+  disableClimateSettingSchedules = false,
   onBack,
   className,
 }: DeviceDetailsProps): JSX.Element | null {
@@ -36,12 +37,13 @@ export function DeviceDetails({
     return null
   }
 
-  const props = {
+  const props: Omit<DeviceDetailsProps, 'deviceId'> = {
     disableLockUnlock,
     disableDeleteAccessCode,
     disableResourceIds,
     disableCreateAccessCode,
     disableEditAccessCode,
+    disableClimateSettingSchedules,
     onBack,
     className,
   }
diff --git a/src/lib/seam/components/DeviceDetails/LockDeviceDetails.tsx b/src/lib/seam/components/DeviceDetails/LockDeviceDetails.tsx
@@ -32,6 +32,7 @@ export function LockDeviceDetails(
     disableEditAccessCode,
     disableDeleteAccessCode,
     disableResourceIds,
+    disableClimateSettingSchedules,
     onBack,
     className,
   } = props
@@ -62,6 +63,7 @@ export function LockDeviceDetails(
         disableEditAccessCode={disableEditAccessCode}
         disableDeleteAccessCode={disableDeleteAccessCode}
         disableResourceIds={disableResourceIds}
+        disableClimateSettingSchedules={disableClimateSettingSchedules}
         onBack={toggleAccessCodesOpen}
         className={className}
       />
diff --git a/src/lib/seam/components/DeviceDetails/ThermostatDeviceDetails.tsx b/src/lib/seam/components/DeviceDetails/ThermostatDeviceDetails.tsx
@@ -45,6 +45,7 @@ export function ThermostatDeviceDetails({
   disableEditAccessCode,
   disableDeleteAccessCode,
   disableResourceIds = false,
+  disableClimateSettingSchedules = false,
 }: ThermostatDeviceDetailsProps): JSX.Element | null {
   const [climateSettingsOpen, setClimateSettingsOpen] = useState(false)
 
@@ -65,6 +66,7 @@ export function ThermostatDeviceDetails({
         disableEditAccessCode={disableEditAccessCode}
         disableDeleteAccessCode={disableDeleteAccessCode}
         disableResourceIds={disableResourceIds}
+        disableClimateSettingSchedules={disableClimateSettingSchedules}
         onBack={() => {
           setClimateSettingsOpen(false)
         }}
@@ -91,25 +93,27 @@ export function ThermostatDeviceDetails({
 
         <div className='seam-thermostat-device-details'>
           <DetailSectionGroup>
-            <DetailSection
-              label={t.scheduledClimates}
-              tooltipContent={t.scheduledClimatesTooltip}
-            >
-              <DetailRow
-                label={
-                  climateSettingSchedules == null
-                    ? t.viewingClimateSchedules
-                    : `${climateSettingSchedules.length} ${climateSettingSchedulesLabel}`
-                }
-                onClick={() => {
-                  setClimateSettingsOpen(true)
-                }}
+            {!disableClimateSettingSchedules && (
+              <DetailSection
+                label={t.scheduledClimates}
+                tooltipContent={t.scheduledClimatesTooltip}
               >
-                <div className='seam-detail-row-rotated-icon'>
-                  <ChevronWideIcon />
-                </div>
-              </DetailRow>
-            </DetailSection>
+                <DetailRow
+                  label={
+                    climateSettingSchedules == null
+                      ? t.viewingClimateSchedules
+                      : `${climateSettingSchedules.length} ${climateSettingSchedulesLabel}`
+                  }
+                  onClick={() => {
+                    setClimateSettingsOpen(true)
+                  }}
+                >
+                  <div className='seam-detail-row-rotated-icon'>
+                    <ChevronWideIcon />
+                  </div>
+                </DetailRow>
+              </DetailSection>
+            )}
 
             <DetailSection
               label={t.currentSettings}
diff --git a/src/lib/seam/components/DeviceTable/DeviceTable.tsx b/src/lib/seam/components/DeviceTable/DeviceTable.tsx
@@ -70,6 +70,7 @@ export function DeviceTable({
   disableEditAccessCode = false,
   disableDeleteAccessCode = false,
   disableResourceIds = false,
+  disableClimateSettingSchedules = false,
   onBack,
   className,
 }: DeviceTableProps = {}): JSX.Element {
@@ -112,6 +113,7 @@ export function DeviceTable({
         disableEditAccessCode={disableEditAccessCode}
         disableDeleteAccessCode={disableDeleteAccessCode}
         disableResourceIds={disableResourceIds}
+        disableClimateSettingSchedules={disableClimateSettingSchedules}
         onBack={() => {
           setSelectedDeviceId(null)
         }}
diff --git a/src/lib/seam/components/common-props.tsx b/src/lib/seam/components/common-props.tsx
@@ -18,6 +18,7 @@ export interface RequiredCommonProps {
   disableEditAccessCode: boolean | undefined
   disableLockUnlock: boolean | undefined
   disableResourceIds: boolean | undefined
+  disableClimateSettingSchedules: boolean | undefined
 }
 
 export type CommonProps = Partial<RequiredCommonProps>

Original file line number	Diff line number	Diff line change
`@@ -46,6 +46,7 @@ const commonProps: R2wcProps<CommonProps> = {`
`46`	`46`	`disableEditAccessCode: 'boolean',`
`47`	`47`	`disableDeleteAccessCode: 'boolean',`
`48`	`48`	`disableResourceIds: 'boolean',`
	`49`	`+ disableClimateSettingSchedules: 'boolean',`
`49`	`50`	`onBack: 'object',`
`50`	`51`	`className: 'string',`
`51`	`52`	`}`
Original file line number	Diff line number	Diff line change
`@@ -18,6 +18,7 @@ export interface RequiredCommonProps {`
`18`	`18`	`disableEditAccessCode: boolean \| undefined`
`19`	`19`	`disableLockUnlock: boolean \| undefined`
`20`	`20`	`disableResourceIds: boolean \| undefined`
	`21`	`+ disableClimateSettingSchedules: boolean \| undefined`
`21`	`22`	`}`
`22`	`23`
`23`	`24`	`export type CommonProps = Partial<RequiredCommonProps>`