simplify error message

Author: kadiryazici

src/lib/errors.ts

@@ -0,0 +1,13 @@
+import { isSeamHttpApiError } from "@seamapi/http/connect"
+
+export function getErrorMessage(error?: Error | null | undefined): string {
+  if (isSeamHttpApiError(error)) {
+    return error.message
+  }
+
+  return t.anUnknownErrorOccurred
+}
+
+const t = {
+  anUnknownErrorOccurred: 'An unknown error occurred',
+}

src/lib/ui/thermostat/ClimatePreset.tsx

@@ -1,4 +1,3 @@
-import type { SeamHttpApiError } from '@seamapi/http/connect'
 import classNames from 'classnames'
 import {
   type HTMLAttributes,
@@ -9,6 +8,7 @@ import {
 } from 'react'
 import { Controller, useForm, type UseFormReturn } from 'react-hook-form'
 
+import { getErrorMessage } from 'lib/errors.js'
 import type {
   FanModeSetting,
   HvacModeSetting,
@@ -71,21 +71,6 @@ interface PresetFormProps {
   withKeyField?: boolean
 }
 
-function useErrorMessage(
-  isError: boolean,
-  error: SeamHttpApiError | null
-): string {
-  return useMemo(() => {
-    if (!isError) return ''
-
-    if (error?.message != null) {
-      return error.message
-    }
-
-    return t.unknownErrorOccured
-  }, [error, isError])
-}
-
 function PresetForm(props: PresetFormProps): JSX.Element {
   const {
     defaultValues,
@@ -286,7 +271,7 @@ function CreateForm({ device, onComplete }: CreateFormProps): JSX.Element {
   const { mutate, isError, error, isPending } =
     useCreateThermostatClimatePreset()
 
-  const errorMessage = useErrorMessage(isError, error)
+  const errorMessage = getErrorMessage(error);
 
   const onSubmit = useCallback(
     (values: PresetFormProps['defaultValues']) => {
@@ -381,7 +366,7 @@ function UpdateForm({
     [device, mutate, onComplete]
   )
 
-  const errorMessage = useErrorMessage(isError, error)
+  const errorMessage = getErrorMessage(error);
 
   return (
     <>

src/lib/ui/thermostat/ClimatePresets.tsx

@@ -1,6 +1,7 @@
 import classNames from 'classnames'
-import { type HTMLAttributes, type ReactNode, useMemo, useState } from 'react'
+import { type HTMLAttributes, type ReactNode, useState } from 'react'
 
+import { getErrorMessage } from 'lib/errors.js'
 import { AddIcon } from 'lib/icons/Add.js'
 import { EditIcon } from 'lib/icons/Edit.js'
 import { FanIcon } from 'lib/icons/Fan.js'
@@ -45,15 +46,7 @@ export function ClimatePresets(props: ClimatePresetsManagement): JSX.Element {
   const { mutate, isError, error, isPending } =
     useDeleteThermostatClimatePreset()
 
-  const errorMessage = useMemo(() => {
-    if (!isError) return ''
-
-    if (error?.message != null) {
-      return error.message
-    }
-
-    return t.unknownErrorOccured
-  }, [error, isError])
+  const errorMessage = getErrorMessage(error);
 
   if (
     selectedClimatePreset != null ||
@@ -254,6 +247,5 @@ const t = {
   createNew: 'Create New',
   delete: 'Delete',
   edit: 'Edit',
-  unknownErrorOccured: 'An unknown error occurred.',
   climatePresetNotFound: 'Climate Preset not found.',
 }