Skip to content

Commit 02732d8

Browse files
committed
Standardize the naming of karmada config in Helm chart
Signed-off-by: wei-chenglai <qazwsx0939059006@gmail.com>
1 parent 006cf70 commit 02732d8

14 files changed

+109
-55
lines changed

charts/karmada/templates/_helpers.tpl

Lines changed: 11 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -112,15 +112,14 @@ app: {{- include "karmada.name" .}}-kube-controller-manager
112112

113113
{{- define "karmada.kubeconfig.volume" -}}
114114
{{- $name := include "karmada.name" . -}}
115-
- name: kubeconfig-secret
115+
- name: karmada-config
116116
secret:
117-
secretName: {{ $name }}-kubeconfig
117+
secretName: {{ $name }}-config
118118
{{- end -}}
119119

120120
{{- define "karmada.kubeconfig.volumeMount" -}}
121-
- name: kubeconfig-secret
122-
subPath: kubeconfig
123-
mountPath: /etc/kubeconfig
121+
- name: karmada-config
122+
mountPath: /etc/karmada/config
124123
{{- end -}}
125124

126125
{{- define "karmada.kubeconfig.caData" -}}
@@ -197,11 +196,11 @@ app: {{$name}}
197196
{{- define "karmada.descheduler.kubeconfig.volume" -}}
198197
{{ $name := include "karmada.name" . }}
199198
{{- if eq .Values.installMode "host" -}}
200-
- name: kubeconfig-secret
199+
- name: karmada-config
201200
secret:
202-
secretName: {{ $name }}-kubeconfig
201+
secretName: {{ $name }}-descheduler-config
203202
{{- else -}}
204-
- name: kubeconfig-secret
203+
- name: karmada-config
205204
secret:
206205
secretName: {{ .Values.descheduler.kubeconfig }}
207206
{{- end -}}
@@ -324,14 +323,14 @@ app: {{- include "karmada.name" .}}-search
324323
- name: k8s-certs
325324
secret:
326325
secretName: {{ $name }}-cert
327-
- name: kubeconfig-secret
326+
- name: karmada-config
328327
secret:
329-
secretName: {{ $name }}-kubeconfig
328+
secretName: {{ $name }}-search-config
330329
{{- else -}}
331330
- name: k8s-certs
332331
secret:
333332
secretName: {{ .Values.search.certs }}
334-
- name: kubeconfig-secret
333+
- name: karmada-config
335334
secret:
336335
secretName: {{ .Values.search.kubeconfig }}
337336
{{- end -}}
@@ -628,7 +627,7 @@ Return the proper Docker Image Registry Secret Names
628627
# case first installation: no `cm/karmada-version` at first, so when you get it, it means `karmada-static-resource-job` finished.
629628
# case restart: already has `cm/karmada-version`, which means `karmada-static-resource-job` already finished.
630629
# case upgrading: already has `cm/karmada-version`, but it may be old version, we should wait until `.data.karmadaVersion` equal to current `.Values.karmadaImageVersion`.
631-
while [[ $(kubectl --kubeconfig /etc/kubeconfig get configmap karmada-version -n {{ .Values.systemNamespace }} -o jsonpath='{.data.karmadaVersion}') != {{ .Values.karmadaImageVersion }} ]]; do
630+
while [[ $(kubectl --kubeconfig /etc/karmada/config/karmada.config get configmap karmada-version -n {{ .Values.systemNamespace }} -o jsonpath='{.data.karmadaVersion}') != {{ .Values.karmadaImageVersion }} ]]; do
632631
echo "wait for karmada-static-resource-job finished"; sleep 2
633632
done
634633

charts/karmada/templates/karmada-agent.yaml

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -33,10 +33,10 @@ subjects:
3333
apiVersion: v1
3434
kind: Secret
3535
metadata:
36-
name: {{ $name }}-kubeconfig
36+
name: {{ $name }}-config
3737
namespace: {{ include "karmada.namespace" . }}
3838
stringData:
39-
kubeconfig: |-
39+
karmada.config: |-
4040
apiVersion: v1
4141
kind: Config
4242
clusters:
@@ -103,7 +103,7 @@ spec:
103103
imagePullPolicy: {{ .Values.agent.image.pullPolicy }}
104104
command:
105105
- /bin/karmada-agent
106-
- --karmada-kubeconfig=/etc/kubeconfig/kubeconfig
106+
- --karmada-kubeconfig=/etc/karmada/config/karmada.config
107107
- --cluster-name={{ .Values.agent.clusterName }}
108108
{{- if .Values.agent.clusterEndpoint }}
109109
- --cluster-api-endpoint={{ .Values.agent.clusterEndpoint }}
@@ -126,15 +126,15 @@ spec:
126126
name: metrics
127127
protocol: TCP
128128
volumeMounts:
129-
- name: kubeconfig
130-
mountPath: /etc/kubeconfig
129+
- name: karmada-config
130+
mountPath: /etc/karmada/config
131131
resources:
132132
{{- toYaml .Values.agent.resources | nindent 12 }}
133133
priorityClassName: {{ .Values.agent.priorityClassName }}
134134
volumes:
135-
- name: kubeconfig
135+
- name: karmada-config
136136
secret:
137-
secretName: {{ $name }}-kubeconfig
137+
secretName: {{ $name }}-config
138138

139139
{{ if .Values.agent.podDisruptionBudget }}
140140
---

charts/karmada/templates/karmada-aggregated-apiserver.yaml

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -45,9 +45,9 @@ spec:
4545
readOnly: true
4646
command:
4747
- /bin/karmada-aggregated-apiserver
48-
- --kubeconfig=/etc/kubeconfig
49-
- --authentication-kubeconfig=/etc/kubeconfig
50-
- --authorization-kubeconfig=/etc/kubeconfig
48+
- --kubeconfig=/etc/karmada/config/karmada.config
49+
- --authentication-kubeconfig=/etc/karmada/config/karmada.config
50+
- --authorization-kubeconfig=/etc/karmada/config/karmada.config
5151
{{- if eq .Values.etcd.mode "external" }}
5252
- --etcd-cafile=/etc/etcd/pki/ca.crt
5353
- --etcd-certfile=/etc/etcd/pki/tls.crt
@@ -99,7 +99,9 @@ spec:
9999
{{- end }}
100100
priorityClassName: {{ .Values.aggregatedApiServer.priorityClassName }}
101101
volumes:
102-
{{- include "karmada.kubeconfig.volume" . | nindent 8 }}
102+
- name: karmada-config
103+
secret:
104+
secretName: {{ $name }}-aggregated-apiserver-config
103105
- name: apiserver-cert
104106
secret:
105107
secretName: {{ $name }}-cert

charts/karmada/templates/karmada-controller-manager.yaml

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,9 @@ spec:
4343
{{- end }}
4444
priorityClassName: {{ .Values.controllerManager.priorityClassName }}
4545
volumes:
46-
{{- include "karmada.kubeconfig.volume" . | nindent 8 }}
46+
- name: karmada-config
47+
secret:
48+
secretName: {{ $name }}-controller-manager-config
4749
initContainers:
4850
{{- include "karmada.initContainer.waitStaticResource" . | nindent 8 }}
4951
containers:
@@ -52,7 +54,7 @@ spec:
5254
imagePullPolicy: {{ .Values.controllerManager.image.pullPolicy }}
5355
command:
5456
- /bin/karmada-controller-manager
55-
- --kubeconfig=/etc/kubeconfig
57+
- --kubeconfig=/etc/karmada/config/karmada.config
5658
- --cluster-status-update-frequency=10s
5759
- --leader-elect-resource-namespace={{ $systemNamespace }}
5860
- --health-probe-bind-address=0.0.0.0:10357

charts/karmada/templates/karmada-descheduler.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ spec:
4949
imagePullPolicy: {{ .Values.descheduler.image.pullPolicy }}
5050
command:
5151
- /bin/karmada-descheduler
52-
- --kubeconfig=/etc/kubeconfig
52+
- --kubeconfig=/etc/karmada/config/karmada.config
5353
- --metrics-bind-address=0.0.0.0:8080
5454
- --health-probe-bind-address=0.0.0.0:10358
5555
- --leader-elect-resource-namespace={{ $systemNamespace }}

charts/karmada/templates/karmada-kubeconfig.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,10 +3,10 @@
33
apiVersion: v1
44
kind: Secret
55
metadata:
6-
name: {{ $name }}-kubeconfig
6+
name: {{ $name }}-config
77
namespace: {{ include "karmada.namespace" . }}
88
stringData:
9-
kubeconfig: |-
9+
karmada.config: |-
1010
apiVersion: v1
1111
kind: Config
1212
clusters:

charts/karmada/templates/karmada-metrics-adapter.yaml

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -43,10 +43,10 @@ spec:
4343
readOnly: true
4444
command:
4545
- /bin/karmada-metrics-adapter
46-
- --kubeconfig=/etc/kubeconfig
46+
- --kubeconfig=/etc/karmada/config/karmada.config
4747
- --metrics-bind-address=:8080
48-
- --authentication-kubeconfig=/etc/kubeconfig
49-
- --authorization-kubeconfig=/etc/kubeconfig
48+
- --authentication-kubeconfig=/etc/karmada/config/karmada.config
49+
- --authorization-kubeconfig=/etc/karmada/config/karmada.config
5050
- --tls-cert-file=/etc/kubernetes/pki/karmada.crt
5151
- --tls-private-key-file=/etc/kubernetes/pki/karmada.key
5252
- --audit-log-path=-
@@ -85,7 +85,9 @@ spec:
8585
{{- end }}
8686
priorityClassName: {{ .Values.metricsAdapter.priorityClassName }}
8787
volumes:
88-
{{- include "karmada.kubeconfig.volume" . | nindent 8 }}
88+
- name: karmada-config
89+
secret:
90+
secretName: {{ $name }}-metrics-adapter-config
8991
- name: apiserver-cert
9092
secret:
9193
secretName: {{ $name }}-cert

charts/karmada/templates/karmada-scheduler.yaml

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ spec:
4949
imagePullPolicy: {{ .Values.scheduler.image.pullPolicy }}
5050
command:
5151
- /bin/karmada-scheduler
52-
- --kubeconfig=/etc/kubeconfig
52+
- --kubeconfig=/etc/karmada/config/karmada.config
5353
- --metrics-bind-address=0.0.0.0:8080
5454
- --health-probe-bind-address=0.0.0.0:10351
5555
- --leader-elect-resource-namespace={{ $systemNamespace }}
@@ -78,7 +78,9 @@ spec:
7878
{{- toYaml .Values.scheduler.resources | nindent 12 }}
7979
priorityClassName: {{ .Values.scheduler.priorityClassName }}
8080
volumes:
81-
{{- include "karmada.kubeconfig.volume" . | nindent 8 }}
81+
- name: karmada-config
82+
secret:
83+
secretName: {{ $name }}-scheduler-config
8284
{{- include "karmada.scheduler.cert.volume" . | nindent 8 }}
8385

8486
{{ if .Values.scheduler.podDisruptionBudget }}

charts/karmada/templates/karmada-search.yaml

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -53,14 +53,13 @@ spec:
5353
- name: etcd-certs
5454
mountPath: /etc/etcd/pki
5555
readOnly: true
56-
- name: kubeconfig-secret
57-
subPath: kubeconfig
58-
mountPath: /etc/kubeconfig
56+
- name: karmada-config
57+
mountPath: /etc/karmada/config
5958
command:
6059
- /bin/karmada-search
61-
- --kubeconfig=/etc/kubeconfig
62-
- --authentication-kubeconfig=/etc/kubeconfig
63-
- --authorization-kubeconfig=/etc/kubeconfig
60+
- --kubeconfig=/etc/karmada/config/karmada.config
61+
- --authentication-kubeconfig=/etc/karmada/config/karmada.config
62+
- --authorization-kubeconfig=/etc/karmada/config/karmada.config
6463
{{- if eq .Values.etcd.mode "external" }}
6564
- --etcd-cafile=/etc/etcd/pki/ca.crt
6665
- --etcd-certfile=/etc/etcd/pki/tls.crt
@@ -160,7 +159,7 @@ spec:
160159
- |
161160
bash <<'EOF'
162161
set -ex
163-
kubectl apply -f /search-apiservice --kubeconfig /etc/kubeconfig
162+
kubectl apply -f /search-apiservice --kubeconfig /etc/karmada/config/karmada.config
164163
EOF
165164
volumeMounts:
166165
- name: {{ $name }}-search-apiservice

charts/karmada/templates/karmada-static-resource-job.yaml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -42,11 +42,11 @@ spec:
4242
bash <<'EOF'
4343
set -ex
4444
kubectl rollout status deployment {{ $name }}-apiserver -n {{ $namespace }}
45-
kubectl apply -k /crds --kubeconfig /etc/kubeconfig
46-
kubectl apply -f /static-resources/system-namespace.yaml --kubeconfig /etc/kubeconfig
47-
kubectl apply -f /static-resources/ --kubeconfig /etc/kubeconfig
45+
kubectl apply -k /crds --kubeconfig /etc/karmada/config/karmada.config
46+
kubectl apply -f /static-resources/system-namespace.yaml --kubeconfig /etc/karmada/config/karmada.config
47+
kubectl apply -f /static-resources/ --kubeconfig /etc/karmada/config/karmada.config
4848
49-
kubectl --kubeconfig /etc/kubeconfig apply -f - <<InnerEOF
49+
kubectl --kubeconfig /etc/karmada/config/karmada.config apply -f - <<InnerEOF
5050
apiVersion: v1
5151
kind: ConfigMap
5252
metadata:

0 commit comments

Comments
 (0)