reqwest 0.13: the trait bound `reqwest::Url: serde::Deserialize<'de>` is not satisfied

[kpcyrd]

Hello!

upgrading from 0.12 to 0.13 I noticed this error and I couldn't figure out which feature to enable to get the old behavior back. Since reqwest::Url seems to be a re-export of url::Url I managed to fix it by adding this to my Cargo.toml:

url = { version = "2", features = ["serde"] }

It might be worth either having this as a feature in reqwest, or making some of the other serde features enable this feature too, or documenting it in CHANGELOG.md.

Thanks!

[0x676e67]

This has nothing to do with reqwest. This is a change in the upstream of url.

servo/rust-url@d6ea13c

[0x676e67]

Enabling the serde feature for URLs in reqwest is not ideal, as the vast majority of users do not require this functionality. The fix you mentioned is already excellent.

[kpcyrd]

Ah, this seems to be the relevant change (which assumed that people depend on url with default features enabled):

servo/rust-url#1071

My suggestion isn't to enable serde unconditionally, but adding url/serde to these existing reqwest features (as they already pull-in serde):

[features]
query = ["dep:serde", "dep:serde_urlencoded"]
form = ["dep:serde", "dep:serde_urlencoded"]
json = ["dep:serde", "dep:serde_json"]