Fixing sapi name pointer bug

Author: seanmorris

source/PhpBase.js

@@ -123,7 +123,6 @@ export class PhpBase extends EventTarget
 
 	inputString(byteString)
 	{
-		console.trace(byteString);
 		this.input(this.encoder.encode(byteString));
 	}
 

source/pib/pib.c

@@ -42,10 +42,14 @@ char *_sapi_name = NULL;
  */
 int EMSCRIPTEN_KEEPALIVE __attribute__((noinline)) pib_init(char *__sapi_name)
 {
-	_sapi_name = __sapi_name;
+	if(!_sapi_name)
+	{
+		_sapi_name = malloc(strlen(__sapi_name) + 1);
+		strcpy(_sapi_name, __sapi_name);
+	}
+
 	putenv("USE_ZEND_ALLOC=0");
 
-	// fprintf(stderr, "SAPI: %s...\n\n", _sapi_name);
 	if(0 == strcmp(_sapi_name, "embed"))
 	{
 		return php_embed_init(0, NULL);

test/basic.mjs

@@ -90,7 +90,7 @@ test('Can maintain memory between executions', async () => {
 });
 
 test('Can refresh memory between executions', async () => {
-	const php = new PhpNode();
+	const php = new PhpNode({});
 
 	let stdOut = '', stdErr = '';
 
@@ -101,10 +101,11 @@ test('Can refresh memory between executions', async () => {
 	await php.run(`<?php $i = 100;`);
 	await php.run(`<?php $i++;`);
 	await php.refresh();
-	await php.run(`<?php ini_set('display_errors', 1); @error_reporting(E_ALL | E_STRICT); echo $i . PHP_EOL;`);
+	await php.run(`<?php ini_set('display_errors', 1); @error_reporting(E_ALL | E_STRICT); var_dump($i) . PHP_EOL;`);
 
-	assert.equal(stdOut, `\nWarning: Undefined variable $i in php-wasm run script on line 1\n\n`);
+	assert.equal(stdOut, `\nWarning: Undefined variable $i in php-wasm run script on line 1\nNULL\n`);
 	assert.equal(stdErr, '');
+
 });
 
 test('Can read files from the local FS through PHP functions', async () => {