Skip to content

Adds close() to HSREnv #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Adds close() to HSREnv #3

wants to merge 1 commit into from

Conversation

@abhishek47kashyap
Copy link

@abhishek47kashyap abhishek47kashyap commented May 5, 2022

Adds close() to class HSREnv, which gets called by pfrl/envs/multiprocess_vector_env.py when Ctrl + C is used to interrupt/stop something (for example, training process in train_agent.py).

Without this, pfrl complains about missing env.close():

Traceback (most recent call last):
  File "/usr/lib/python3.8/multiprocessing/process.py", line 315, in _bootstrap
    self.run()
  File "/usr/lib/python3.8/multiprocessing/process.py", line 108, in run
    self._target(*self._args, **self._kwargs)
  File "/usr/local/lib/python3.8/dist-packages/pfrl/envs/multiprocess_vector_env.py", line 36, in worker
    env.close()
AttributeError: 'GraspEnv' object has no attribute 'close'

The close() method simply disconnects from the server, as explained here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@abhishek47kashyap