Merge pull request rails#47461 from Shopify/docker-node-latest-lts

Use an actual version in .node-version

Author: byroot

railties/lib/rails/generators/app_base.rb

@@ -15,6 +15,8 @@ class AppBase < Base # :nodoc:
       include Database
       include AppName
 
+      NODE_TLS_VERSION = "18.15.0"
+
       attr_accessor :rails_template
       add_shebang_option!
 
@@ -458,10 +460,14 @@ def using_node?
         options[:javascript] && options[:javascript] != "importmap"
       end
 
-      def dockerfile_node_version
-        using_node? and `node --version`[/\d+\.\d+\.\d+/]
-      rescue
-        "lts"
+      def node_version
+        if using_node?
+          ENV.fetch("NODE_VERSION") do
+            `node --version`[/\d+\.\d+\.\d+/]
+          rescue
+            NODE_TLS_VERSION
+          end
+        end
       end
 
       def dockerfile_yarn_version

railties/lib/rails/generators/rails/app/templates/Dockerfile.tt

@@ -23,7 +23,7 @@ RUN apt-get update -qq && \
 
 <% if using_node? -%>
 # Install JavaScript dependencies
-ARG NODE_VERSION=<%= dockerfile_node_version %>
+ARG NODE_VERSION=<%= node_version %>
 ARG YARN_VERSION=<%= dockerfile_yarn_version %>
 ENV PATH=/usr/local/node/bin:$PATH
 RUN curl -sL https://github.com/nodenv/node-build/archive/master.tar.gz | tar xz -C /tmp/ && \

railties/lib/rails/generators/rails/app/templates/node-version.tt

@@ -1 +1 @@
-<%= ENV["NODE_VERSION"] || dockerfile_node_version %>
+<%= node_version %>