Improve title tag for new apps (rails#51134)

viktorianer · web-flow · commit 052b5ed69a10 · 2024-02-20T13:32:33.000-08:00
* Fix regex for application name assertion

* Change title tag to default to a titleized app name
diff --git a/railties/lib/rails/generators/rails/app/templates/app/views/layouts/application.html.erb.tt b/railties/lib/rails/generators/rails/app/templates/app/views/layouts/application.html.erb.tt
@@ -1,7 +1,7 @@
 <!DOCTYPE html>
 <html>
   <head>
-    <title><%%= content_for(:title) || "<%= camelized %>" %></title>
+    <title><%%= content_for(:title) || "<%= app_name.titleize %>" %></title>
     <meta name="viewport" content="width=device-width,initial-scale=1">
     <meta name="apple-mobile-web-app-capable" content="yes">
     <%%= csrf_meta_tags %>
diff --git a/railties/test/generators/app_generator_test.rb b/railties/test/generators/app_generator_test.rb
@@ -421,7 +421,7 @@ def test_application_names_are_not_singularized
 
   def test_application_name_is_normalized_in_config
     run_generator [File.join(destination_root, "MyWebSite"), "-d", "postgresql"]
-    assert_file "MyWebSite/app/views/layouts/application.html.erb", /<title><%= content_for(:title) || "MyWebSite" %><\/title>/
+    assert_file "MyWebSite/app/views/layouts/application.html.erb", /content_for\(:title\) \|\| "My Web Site"/
     assert_file "MyWebSite/config/database.yml", /my_web_site_production/
   end
 
