Merge pull request rails#54080 from byroot/mb-chars-chilled-strings

Fix `String#mb_chars` to never mutate the original String

Author: byroot

activesupport/lib/active_support/multibyte/chars.rb

@@ -55,7 +55,10 @@ class Chars
       # Creates a new Chars instance by wrapping _string_.
       def initialize(string)
         @wrapped_string = string
-        @wrapped_string.force_encoding(Encoding::UTF_8) unless @wrapped_string.frozen?
+        if string.encoding != Encoding::UTF_8
+          @wrapped_string = @wrapped_string.dup
+          @wrapped_string.force_encoding(Encoding::UTF_8)
+        end
       end
 
       # Forward all undefined methods to the wrapped string.

activesupport/test/multibyte_test_helpers.rb

@@ -1,9 +1,10 @@
 # frozen_string_literal: true
 
 module MultibyteTestHelpers
-  UNICODE_STRING = "こにちわ"
-  ASCII_STRING = "ohayo"
-  BYTE_STRING = (+"\270\236\010\210\245").force_encoding("ASCII-8BIT").freeze
+  # We use Symbol#to_s to create these strings so warnings are emitted if they are mutated
+  UNICODE_STRING = :"こにちわ".to_s
+  ASCII_STRING = :"ohayo".to_s
+  BYTE_STRING = "\270\236\010\210\245".b.freeze
 
   def chars(str)
     ActiveSupport::Multibyte::Chars.new(str)