Add default svg icon in generated application layout (rails#50629)

dhh · web-flow · commit 0ecbb1693991 · 2024-01-07T12:32:43.000-05:00
* SVG icon is support by Chrome/Firefox

So prefer that over PNG.

* Also included

* No need for a size when we only have one
diff --git a/railties/lib/rails/generators/rails/app/app_generator.rb b/railties/lib/rails/generators/rails/app/app_generator.rb
@@ -489,6 +489,7 @@ def delete_public_files_if_api_option
           remove_file "public/426.html"
           remove_file "public/500.html"
           remove_file "public/icon.png"
+          remove_file "public/icon.svg"
         end
       end
 
diff --git a/railties/lib/rails/generators/rails/app/templates/app/views/layouts/application.html.erb.tt b/railties/lib/rails/generators/rails/app/templates/app/views/layouts/application.html.erb.tt
@@ -11,7 +11,8 @@
 
     <link rel="manifest" href="/manifest.json">
     <link rel="icon" href="/icon.png" type="image/png">
-    <link rel="apple-touch-icon" href="/icon.png" sizes="512x512">
+    <link rel="icon" href="/icon.svg" type="image/svg+xml">
+    <link rel="apple-touch-icon" href="/icon.png">
     <%- if options[:skip_hotwire] || options[:skip_javascript] -%>
     <%%= stylesheet_link_tag "application" %>
     <%- else -%>
diff --git a/railties/lib/rails/generators/rails/app/templates/public/icon.svg b/railties/lib/rails/generators/rails/app/templates/public/icon.svg
@@ -0,0 +1,3 @@
+<svg width="100" height="100" xmlns="http://www.w3.org/2000/svg">
+  <rect width="100%" height="100%" fill="red"/>
+</svg>
diff --git a/railties/test/generators/api_app_generator_test.rb b/railties/test/generators/api_app_generator_test.rb
@@ -183,6 +183,7 @@ def skipped_files
          public/426.html
          public/500.html
          public/icon.png
+         public/icon.svg
       )
     end
 end

Original file line number	Diff line number	Diff line change
`@@ -183,6 +183,7 @@ def skipped_files`
`183`	`183`	`public/426.html`
`184`	`184`	`public/500.html`
`185`	`185`	`public/icon.png`
	`186`	`+ public/icon.svg`
`186`	`187`	`)`
`187`	`188`	`end`
`188`	`189`	`end`