Skip to content

Commit 154f7c2

Browse files
committed
Register autoload for ActiveJob::Arguments
Since rails#50715, there are cases where `ActiveJob::Arguments` is used but not required anymore in the test environment. This could be a test for a custom argument serializer. One solution could be to add a require "active_job/arguments" in all the usages, but that isn't a convention we follow in Rails. Instead, let's register the autoload for `ActiveJob::Arguments` in `active_job.rb` so that it's always available when needed.
1 parent 8e20f5d commit 154f7c2

File tree

5 files changed

+3
-6
lines changed

5 files changed

+3
-6
lines changed

actionmailer/test/mailers/delayed_mailer.rb

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,5 @@
11
# frozen_string_literal: true
22

3-
require "active_job/arguments"
4-
53
class DelayedMailerError < StandardError; end
64

75
class DelayedMailer < ActionMailer::Base

activejob/lib/active_job.rb

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,9 @@ module ActiveJob
3636

3737
autoload :Base
3838
autoload :QueueAdapters
39+
autoload :Arguments
40+
autoload :DeserializationError, "active_job/arguments"
41+
autoload :SerializationError, "active_job/arguments"
3942

4043
eager_autoload do
4144
autoload :Serializers

activejob/lib/active_job/enqueuing.rb

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,5 @@
11
# frozen_string_literal: true
22

3-
require "active_job/arguments"
4-
53
module ActiveJob
64
# Provides behavior for enqueuing jobs.
75

activejob/lib/active_job/execution.rb

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
# frozen_string_literal: true
22

33
require "active_support/rescuable"
4-
require "active_job/arguments"
54

65
module ActiveJob
76
# = Active Job \Execution

activejob/test/cases/argument_serialization_test.rb

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33
require "json"
44
require "bigdecimal"
55
require "helper"
6-
require "active_job/arguments"
76
require "models/person"
87
require "active_support/core_ext/hash/indifferent_access"
98
require "active_support/core_ext/integer/time"

0 commit comments

Comments
 (0)