Merge pull request rails#50170 from y-yagi/fix-db_system_change-to-trilogy

Don't add `default-mysql-client` when running `db:system:change` to Trilogy

Author: eileencodes

railties/lib/rails/generators/database.rb

@@ -30,7 +30,7 @@ def gem_for_database(database = options[:database])
       def docker_for_database_build(database = options[:database])
         case database
         when "mysql"          then "build-essential default-libmysqlclient-dev git"
-        when "trilogy"        then "build-essential default-libmysqlclient-dev git"
+        when "trilogy"        then "build-essential git"
         when "postgresql"     then "build-essential git libpq-dev"
         when "sqlite3"        then "build-essential git"
         else nil
@@ -40,7 +40,7 @@ def docker_for_database_build(database = options[:database])
       def docker_for_database_deploy(database = options[:database])
         case database
         when "mysql"          then "curl default-mysql-client libvips"
-        when "trilogy"        then "curl default-mysql-client libvips"
+        when "trilogy"        then "curl libvips"
         when "postgresql"     then "curl libvips postgresql-client"
         when "sqlite3"        then "curl libsqlite3-0 libvips"
         else nil

railties/test/generators/db_system_change_generator_test.rb

@@ -90,6 +90,26 @@ class ChangeGeneratorTest < Rails::Generators::TestCase
             end
           end
 
+          test "change to trilogy" do
+            run_generator ["--to", "trilogy"]
+
+            assert_file("config/database.yml") do |content|
+              assert_match "adapter: trilogy", content
+              assert_match "database: tmp_production", content
+            end
+
+            assert_file("Gemfile") do |content|
+              assert_match "# Use trilogy as the database for Active Record", content
+              assert_match 'gem "trilogy", "~> 2.4"', content
+            end
+
+            assert_file("Dockerfile") do |content|
+              assert_match "build-essential git", content
+              assert_match "curl libvips", content
+              assert_no_match "default-libmysqlclient-dev", content
+            end
+          end
+
           test "change from versioned gem to other versioned gem" do
             run_generator ["--to", "sqlite3"]
             run_generator ["--to", "mysql", "--force"]