Skip to content

Commit 1cf2975

Browse files
committed
Address test_does_not_raise_if_no_fk_violations failure
Replace `authors` with `movies` fixture because `authors` references `author_address` which would causes foreign key violations. Refer the CI failure at https://buildkite.com/rails/rails/builds/81644#c8fd1c44-6258-41d5-bdd6-000de8d102ed ```ruby $ cd activerecord $ ARCONN=postgresql bin/test test/cases/fixtures_test.rb -n "/^(?:FixturesTest#(?:test_bulk_insert_multiple_table_with_a_multi_statement_query)|FixturesWithForeignKeyViolationsTest#(?:test_does_not_raise_if_no_fk_violations))$/" --seed 27461 Using postgresql Run options: -n "/^(?:FixturesTest#(?:test_bulk_insert_multiple_table_with_a_multi_statement_query)|FixturesWithForeignKeyViolationsTest#(?:test_does_not_raise_if_no_fk_violations))$/" --seed 27461 .E Error: FixturesWithForeignKeyViolationsTest#test_does_not_raise_if_no_fk_violations: RuntimeError: Foreign key violations found in your fixture data. Ensure you aren't referring to labels that don't exist on associations. /home/yahonda/src/github.com/rails/rails/activerecord/lib/active_record/fixtures.rb:641:in `block in insert' /home/yahonda/src/github.com/rails/rails/activerecord/lib/active_record/fixtures.rb:629:in `each' /home/yahonda/src/github.com/rails/rails/activerecord/lib/active_record/fixtures.rb:629:in `insert' /home/yahonda/src/github.com/rails/rails/activerecord/lib/active_record/fixtures.rb:615:in `read_and_insert' /home/yahonda/src/github.com/rails/rails/activerecord/lib/active_record/fixtures.rb:567:in `create_fixtures' /home/yahonda/src/github.com/rails/rails/activerecord/test/cases/fixtures_test.rb:846:in `block (2 levels) in test_does_not_raise_if_no_fk_violations' /home/yahonda/src/github.com/rails/rails/activesupport/lib/active_support/testing/assertions.rb:34:in `assert_nothing_raised' /home/yahonda/src/github.com/rails/rails/activerecord/test/cases/fixtures_test.rb:845:in `block in test_does_not_raise_if_no_fk_violations' /home/yahonda/src/github.com/rails/rails/activerecord/test/cases/fixtures_test.rb:859:in `with_verify_foreign_keys_for_fixtures' /home/yahonda/src/github.com/rails/rails/activerecord/test/cases/fixtures_test.rb:844:in `test_does_not_raise_if_no_fk_violations' bin/test test/cases/fixtures_test.rb:837 Finished in 0.212500s, 9.4118 runs/s, 14.1176 assertions/s. 2 runs, 3 assertions, 0 failures, 1 errors, 0 skips $ ```
1 parent fb1ab34 commit 1cf2975

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

activerecord/test/cases/fixtures_test.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -95,11 +95,11 @@ def test_bulk_insert_multiple_table_with_a_multi_statement_query
9595
subscriber = InsertQuerySubscriber.new
9696
subscription = ActiveSupport::Notifications.subscribe("sql.active_record", subscriber)
9797

98-
create_fixtures("bulbs", "authors", "computers")
98+
create_fixtures("bulbs", "movies", "computers")
9999

100100
expected_sql = <<~EOS.chop
101101
INSERT INTO #{ActiveRecord::Base.connection.quote_table_name("bulbs")} .*
102-
INSERT INTO #{ActiveRecord::Base.connection.quote_table_name("authors")} .*
102+
INSERT INTO #{ActiveRecord::Base.connection.quote_table_name("movies")} .*
103103
INSERT INTO #{ActiveRecord::Base.connection.quote_table_name("computers")} .*
104104
EOS
105105
assert_equal 1, subscriber.events.size

0 commit comments

Comments
 (0)