Merge pull request rails#49628 from Shopify/enable-minitest-assert-predicate-rubocop-rule

[Tests only] Enable `Minitest/AssertPredicate` rule

Author: rafaelfranca

.rubocop.yml

@@ -353,6 +353,9 @@ Performance/RedundantStringChars:
 Performance/StringInclude:
   Enabled: true
 
+Minitest/AssertPredicate:
+  Enabled: true
+
 Minitest/AssertRaisesWithRegexpArgument:
   Enabled: true
 

actioncable/test/channel/test_case_test.rb

@@ -44,7 +44,7 @@ def test_no_subscribe
   def test_subscribe
     subscribe
 
-    assert subscription.confirmed?
+    assert_predicate subscription, :confirmed?
     assert_not subscription.rejected?
     assert_equal 1, connection.transmissions.size
     assert_equal ActionCable::INTERNAL[:message_types][:confirmation],
@@ -77,7 +77,7 @@ def test_rejection
     subscribe
 
     assert_not subscription.confirmed?
-    assert subscription.rejected?
+    assert_predicate subscription, :rejected?
     assert_equal 1, connection.transmissions.size
     assert_equal ActionCable::INTERNAL[:message_types][:rejection],
                  connection.transmissions.last["type"]

actioncable/test/client_test.rb

@@ -325,7 +325,7 @@ def test_remote_disconnect_client
       assert_equal({ "type" => "disconnect", "reason" => "remote", "reconnect" => true }, c.read_message)
 
       c.wait_for_close
-      assert(c.closed?)
+      assert_predicate(c, :closed?)
     end
   end
 
@@ -342,7 +342,7 @@ def test_remote_disconnect_client_with_reconnect
       assert_equal({ "type" => "disconnect", "reason" => "remote", "reconnect" => false }, c.read_message)
 
       c.wait_for_close
-      assert(c.closed?)
+      assert_predicate(c, :closed?)
     end
   end
 

actioncable/test/subscription_adapter/postgresql_test.rb

@@ -62,7 +62,7 @@ def active?
 
     ActiveRecord::Base.connection_handler.clear_reloadable_connections!
 
-    assert adapter.active?
+    assert_predicate adapter, :active?
   end
 
   def test_default_subscription_connection_identifier

actionmailbox/test/unit/mailbox/bouncing_test.rb

@@ -31,7 +31,7 @@ class ActionMailbox::Base::BouncingTest < ActiveSupport::TestCase
       BouncingWithReplyMailbox.receive @inbound_email
     end
 
-    assert @inbound_email.bounced?
+    assert_predicate @inbound_email, :bounced?
     assert_emails 1
 
     mail = ActionMailer::Base.deliveries.last
@@ -44,7 +44,7 @@ class ActionMailbox::Base::BouncingTest < ActiveSupport::TestCase
       BouncingWithImmediateReplyMailbox.receive @inbound_email
     end
 
-    assert @inbound_email.bounced?
+    assert_predicate @inbound_email, :bounced?
     assert_emails 1
 
     mail = ActionMailer::Base.deliveries.last

actionmailbox/test/unit/mailbox/callbacks_test.rb

@@ -61,15 +61,15 @@ class ActionMailbox::Base::CallbacksTest < ActiveSupport::TestCase
 
   test "bouncing in a callback terminates processing" do
     BouncingCallbackMailbox.receive @inbound_email
-    assert @inbound_email.bounced?
+    assert_predicate @inbound_email, :bounced?
     assert_equal [ "Pre-bounce", "Bounce" ], $before_processing
     assert_not $processed
     assert_not $after_processing
   end
 
   test "marking the inbound email as delivered in a callback terminates processing" do
     DiscardingCallbackMailbox.receive @inbound_email
-    assert @inbound_email.delivered?
+    assert_predicate @inbound_email, :delivered?
     assert_equal [ "Pre-discard", "Discard" ], $before_processing
     assert_not $processed
     assert_not $after_processing

actionmailbox/test/unit/mailbox/state_test.rb

@@ -33,19 +33,19 @@ class ActionMailbox::Base::StateTest < ActiveSupport::TestCase
 
   test "successful mailbox processing leaves inbound email in delivered state" do
     SuccessfulMailbox.receive @inbound_email
-    assert @inbound_email.delivered?
+    assert_predicate @inbound_email, :delivered?
     assert_equal "I was processed", $processed
   end
 
   test "unsuccessful mailbox processing leaves inbound email in failed state" do
     UnsuccessfulMailbox.receive @inbound_email
-    assert @inbound_email.failed?
+    assert_predicate @inbound_email, :failed?
     assert_equal :failure, $processed
   end
 
   test "bounced inbound emails are not delivered" do
     BouncingMailbox.receive @inbound_email
-    assert @inbound_email.bounced?
+    assert_predicate @inbound_email, :bounced?
     assert_equal :bounced, $processed
   end
 end

actionmailbox/test/unit/relayer_test.rb

@@ -19,7 +19,7 @@ class RelayerTest < ActiveSupport::TestCase
       result = @relayer.relay(file_fixture("welcome.eml").read)
       assert_equal "2.0.0", result.status_code
       assert_equal "Successfully relayed message to ingress", result.message
-      assert result.success?
+      assert_predicate result, :success?
       assert_not result.failure?
 
       assert_requested :post, URL, body: file_fixture("welcome.eml").read,
@@ -34,7 +34,7 @@ class RelayerTest < ActiveSupport::TestCase
       assert_equal "4.7.0", result.status_code
       assert_equal "Invalid credentials for ingress", result.message
       assert_not result.success?
-      assert result.failure?
+      assert_predicate result, :failure?
     end
 
     test "unsuccessfully relaying due to an unspecified server error" do
@@ -44,7 +44,7 @@ class RelayerTest < ActiveSupport::TestCase
       assert_equal "4.0.0", result.status_code
       assert_equal "HTTP 500", result.message
       assert_not result.success?
-      assert result.failure?
+      assert_predicate result, :failure?
     end
 
     test "unsuccessfully relaying due to a gateway timeout" do
@@ -54,7 +54,7 @@ class RelayerTest < ActiveSupport::TestCase
       assert_equal "4.0.0", result.status_code
       assert_equal "HTTP 504", result.message
       assert_not result.success?
-      assert result.failure?
+      assert_predicate result, :failure?
     end
 
     test "unsuccessfully relaying due to ECONNRESET" do
@@ -64,7 +64,7 @@ class RelayerTest < ActiveSupport::TestCase
       assert_equal "4.4.2", result.status_code
       assert_equal "Network error relaying to ingress: Connection reset by peer", result.message
       assert_not result.success?
-      assert result.failure?
+      assert_predicate result, :failure?
     end
 
     test "unsuccessfully relaying due to connection failure" do
@@ -74,7 +74,7 @@ class RelayerTest < ActiveSupport::TestCase
       assert_equal "4.4.2", result.status_code
       assert_equal "Network error relaying to ingress: Failed to open TCP connection to example.com:443", result.message
       assert_not result.success?
-      assert result.failure?
+      assert_predicate result, :failure?
     end
 
     test "unsuccessfully relaying due to client-side timeout" do
@@ -84,7 +84,7 @@ class RelayerTest < ActiveSupport::TestCase
       assert_equal "4.4.2", result.status_code
       assert_equal "Timed out relaying to ingress", result.message
       assert_not result.success?
-      assert result.failure?
+      assert_predicate result, :failure?
     end
 
     test "unsuccessfully relaying due to an unhandled exception" do
@@ -94,7 +94,7 @@ class RelayerTest < ActiveSupport::TestCase
       assert_equal "4.0.0", result.status_code
       assert_equal "Error relaying to ingress: Something went wrong", result.message
       assert_not result.success?
-      assert result.failure?
+      assert_predicate result, :failure?
     end
   end
 end

actionmailbox/test/unit/router_test.rb

@@ -136,7 +136,7 @@ class RouterTest < ActiveSupport::TestCase
       assert_raises(ActionMailbox::Router::RoutingError) do
         @router.route inbound_email
       end
-      assert inbound_email.bounced?
+      assert_predicate inbound_email, :bounced?
     end
 
     test "invalid address" do

actionpack/test/controller/live_stream_test.rb

@@ -324,9 +324,9 @@ def ignore_client_disconnect
     tests TestController
 
     def assert_stream_closed
-      assert response.stream.closed?, "stream should be closed"
-      assert response.committed?,     "response should be committed"
-      assert response.sent?,          "response should be sent"
+      assert_predicate response.stream, :closed?, "stream should be closed"
+      assert_predicate response, :committed?,     "response should be committed"
+      assert_predicate response, :sent?,          "response should be sent"
     end
 
     def capture_log_output