Merge pull request rails#46126 from alexandreruban/fix-as-json-action-text-attachables

Fix ActionText::Attachable#as_json

Author: rafaelfranca

actiontext/lib/action_text/attachable.rb

@@ -64,7 +64,7 @@ def previewable_attachable?
     end
 
     def as_json(*)
-      super.merge(attachable_sgid: attachable_sgid)
+      super.merge("attachable_sgid" => persisted? ? attachable_sgid : nil)
     end
 
     def to_trix_content_attachment_partial_path

actiontext/test/unit/attachable_test.rb

@@ -0,0 +1,43 @@
+# frozen_string_literal: true
+
+require "test_helper"
+
+class ActionText::AttachableTest < ActiveSupport::TestCase
+  test "as_json is a hash when the attachable is persisted" do
+    freeze_time do
+      attachable = ActiveStorage::Blob.create_after_unfurling!(io: StringIO.new("test"), filename: "test.txt", key: 123)
+      attributes = {
+        id: attachable.id,
+        key: "123",
+        filename: "test.txt",
+        content_type: "text/plain",
+        metadata: { identified: true },
+        service_name: "test",
+        byte_size: 4,
+        checksum: "CY9rzUYh03PK3k6DJie09g==",
+        created_at: Time.zone.now.as_json,
+        attachable_sgid: attachable.attachable_sgid
+      }.deep_stringify_keys
+
+      assert_equal attributes, attachable.as_json
+    end
+  end
+
+  test "as_json is a hash when the attachable is a new record" do
+    attachable = ActiveStorage::Blob.build_after_unfurling(io: StringIO.new("test"), filename: "test.txt", key: 123)
+    attributes = {
+      id: nil,
+      key: "123",
+      filename: "test.txt",
+      content_type: "text/plain",
+      metadata: { identified: true },
+      service_name: "test",
+      byte_size: 4,
+      checksum: "CY9rzUYh03PK3k6DJie09g==",
+      created_at: nil,
+      attachable_sgid: nil
+    }.deep_stringify_keys
+
+    assert_equal attributes, attachable.as_json
+  end
+end