Improve InvariableError, UnpreviewableError and UnrepresentableError message

Mention which blob can't be transformed/previewed and what content_type
it has.

Co-authored-by: zzak <[email protected]>

Author: 2 people

activestorage/CHANGELOG.md

@@ -1,3 +1,9 @@
+*   Improve InvariableError, UnpreviewableError and UnrepresentableError message.
+
+    Include Blob ID and content_type in the messages.
+
+    *Petrik de Heus*
+
 *   Mark proxied files as `immutable` in their Cache-Control header
 
     *Nate Matykiewicz*

activestorage/app/models/active_storage/blob/representable.rb

@@ -35,7 +35,7 @@ def variant(transformations)
     if variable?
       variant_class.new(self, ActiveStorage::Variation.wrap(transformations).default_to(default_variant_transformations))
     else
-      raise ActiveStorage::InvariableError
+      raise ActiveStorage::InvariableError, "Can't transform blob with ID=#{id} and content_type=#{content_type}"
     end
   end
 
@@ -64,7 +64,7 @@ def preview(transformations)
     if previewable?
       ActiveStorage::Preview.new(self, transformations)
     else
-      raise ActiveStorage::UnpreviewableError
+      raise ActiveStorage::UnpreviewableError, "No previewer found for blob with ID=#{id} and content_type=#{content_type}"
     end
   end
 
@@ -89,7 +89,7 @@ def representation(transformations)
     when variable?
       variant transformations
     else
-      raise ActiveStorage::UnrepresentableError
+      raise ActiveStorage::UnrepresentableError, "No previewer found and can't transform blob with ID=#{id} and content_type=#{content_type}"
     end
   end
 

activestorage/test/models/preview_test.rb

@@ -58,8 +58,7 @@ class ActiveStorage::PreviewTest < ActiveSupport::TestCase
 
   test "previewing an unpreviewable blob" do
     blob = create_file_blob
-
-    assert_raises ActiveStorage::UnpreviewableError do
+    assert_raises ActiveStorage::UnpreviewableError, match: /blob with ID=\d+ and content_type=image\/jpeg/ do
       blob.preview resize_to_limit: [640, 280]
     end
   end

activestorage/test/models/representation_test.rb

@@ -42,8 +42,7 @@ class ActiveStorage::RepresentationTest < ActiveSupport::TestCase
 
   test "representing an unrepresentable blob" do
     blob = create_blob
-
-    assert_raises ActiveStorage::UnrepresentableError do
+    assert_raises ActiveStorage::UnrepresentableError, match: /blob with ID=\d+ and content_type=text\/plain/ do
       blob.representation resize_to_limit: [100, 100]
     end
   end

activestorage/test/models/variant_test.rb

@@ -158,7 +158,7 @@ class ActiveStorage::VariantTest < ActiveSupport::TestCase
   end
 
   test "variation of invariable blob" do
-    assert_raises ActiveStorage::InvariableError do
+    assert_raises ActiveStorage::InvariableError, match: /blob with ID=\d+ and content_type=application\/pdf/ do
       create_file_blob(filename: "report.pdf", content_type: "application/pdf").variant(resize_to_limit: [100, 100])
     end
   end