Merge pull request rails#53579 from y-yagi/do_not_install_unneeded_package

Don't install a package for system test when applications don't use it

Author: kamipo

railties/lib/rails/generators/app_base.rb

@@ -609,6 +609,14 @@ def dockerfile_build_packages
         packages.compact.sort
       end
 
+      def ci_packages
+        if depends_on_system_test?
+          dockerfile_build_packages << "google-chrome-stable"
+        else
+          dockerfile_build_packages
+        end
+      end
+
       def css_gemfile_entry
         return if options[:api]
         return unless options[:css]

railties/lib/rails/generators/rails/app/templates/github/ci.yml.tt

@@ -100,7 +100,7 @@ jobs:
     <%- end -%>
     steps:
       - name: Install packages
-        run: sudo apt-get update && sudo apt-get install --no-install-recommends -y google-chrome-stable <%= dockerfile_base_packages.join(" ") %>
+        run: sudo apt-get update && sudo apt-get install --no-install-recommends -y <%= ci_packages.join(" ") %>
 
       - name: Checkout code
         uses: actions/checkout@v4

railties/lib/rails/generators/rails/plugin/templates/github/ci.yml.tt

@@ -64,7 +64,7 @@ jobs:
     <%- end -%>
     steps:
       - name: Install packages
-        run: sudo apt-get update && sudo apt-get install --no-install-recommends -y google-chrome-stable <%= dockerfile_base_packages.join(" ") %>
+        run: sudo apt-get update && sudo apt-get install --no-install-recommends -y <%= ci_packages.join(" ") %>
 
       - name: Checkout code
         uses: actions/checkout@v4

railties/test/generators/api_app_generator_test.rb

@@ -62,6 +62,7 @@ def test_api_modified_files
       assert_no_match(/test:system/, content)
       assert_no_match(/screenshots/, content)
       assert_no_match(/scan_js/, content)
+      assert_no_match(/google-chrome-stable/, content)
     end
   end
 

railties/test/generators/app_generator_test.rb

@@ -519,6 +519,10 @@ def test_generator_if_skip_system_test_is_given
     assert_directory("test")
 
     assert_no_directory("test/system")
+
+    assert_file ".github/workflows/ci.yml" do |content|
+      assert_no_match(/google-chrome-stable/, content)
+    end
   end
 
   def test_does_not_generate_system_test_files_if_skip_system_test_is_given