Skip to content

Commit 395f44d

Browse files
committed
Prefer ActionDispatch parameter parsing over Rack
They're not likely to ever differ in behaviour for any of this file's assertions, but we want to be strict about only calling Rack's parser when we intend to / cannot avoid it, and this is not that.
1 parent 1e7e9aa commit 395f44d

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

actionpack/test/journey/router_test.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -494,7 +494,7 @@ def _generate(route_name, options, recall)
494494
end
495495
path = @route_set.path_for(options, route_name)
496496
uri = URI.parse path
497-
params = Rack::Utils.parse_nested_query(uri.query).symbolize_keys
497+
params = ActionDispatch::ParamBuilder.from_query_string(uri.query).symbolize_keys
498498
[uri.path, params]
499499
end
500500

0 commit comments

Comments
 (0)