Skip to content

Commit 464e0bc

Browse files
committed
No need to update version for Rails
This version is already updated in the railties framework. The version.rb file in the root was never used.
1 parent 3be497e commit 464e0bc

File tree

3 files changed

+17
-23
lines changed

3 files changed

+17
-23
lines changed

tools/releaser/lib/releaser.rb

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -190,12 +190,10 @@ def gemspec(framework)
190190
end
191191

192192
def update_versions(framework)
193+
return if framework == "rails"
194+
193195
Dir.chdir(root) do
194-
if framework == "rails"
195-
glob = "version.rb"
196-
else
197-
glob = "#{framework}/lib/*/gem_version.rb"
198-
end
196+
glob = "#{framework}/lib/*/gem_version.rb"
199197

200198
file = Dir[glob].first
201199
ruby = File.read(file)
@@ -258,7 +256,7 @@ def framework_name(framework)
258256
CHANGELOG
259257
Gemfile.lock
260258
package.json
261-
version.rb
259+
gem_version.rb
262260
tasks/release.rb
263261
releaser.rb
264262
)

tools/releaser/test/releaser_test.rb

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -134,6 +134,19 @@ def test_update_versions_updates_the_version_of_a_gem_and_the_npm_package
134134
end
135135
end
136136

137+
def test_update_versions_with_rails_does_nothing
138+
Dir.mktmpdir("rails") do |root|
139+
FileUtils.cp_r(File.expand_path("fixtures", __dir__), root)
140+
141+
root = "#{root}/fixtures"
142+
143+
releaser = Releaser.new(root, "5.0.0")
144+
releaser.update_versions("rails")
145+
146+
assert_equal false, File.exist?("#{root}/rails/lib/rails/gem_version.rb")
147+
end
148+
end
149+
137150
def test_release_notes_returns_the_release_notes_for_a_framework
138151
Dir.mktmpdir("rails") do |root|
139152
FileUtils.cp_r(File.expand_path("fixtures", __dir__), root)

version.rb

Lines changed: 0 additions & 17 deletions
This file was deleted.

0 commit comments

Comments
 (0)