Skip to content

Commit 4a23cb3

Browse files
author
David Heinemeier Hansson
authored
Output Action Cable JS without transpiling and as ESM (rails#42856)
* Output Action Cable JS without transpiling and as ESM * Retain umd version under the old name, generate ESM version + duplicate under new name * Precompile JavaScripts for direct asset pipeline use * We've dropped support for IE11 * Include deprecation notice for the old file reference Thanks @rafaelfranca 👍 * Allow app to opt out of precompiling actioncable js assets cc @rafaelfranca * Add changelog entries
1 parent 58dc8b6 commit 4a23cb3

File tree

13 files changed

+1134
-287
lines changed

13 files changed

+1134
-287
lines changed

actioncable/.eslintrc

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,8 @@
33
"rules": {
44
"semi": ["error", "never"],
55
"quotes": ["error", "double"],
6-
"no-unused-vars": ["error", { "vars": "all", "args": "none" }]
6+
"no-unused-vars": ["error", { "vars": "all", "args": "none" }],
7+
"no-console": "off"
78
},
89
"plugins": [
910
"import"

actioncable/CHANGELOG.md

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,15 @@
1+
* Compile ESM package that can be used directly in the browser as actioncable.esm.js.
2+
3+
*DHH*
4+
5+
* Move action_cable.js to actioncable.js to match naming convention used for other Rails frameworks, and use JS console to communicate the deprecation.
6+
7+
*DHH*
8+
9+
* Stop transpiling the UMD package generated as actioncable.js and drop the IE11 testing that relied on that.
10+
11+
*DHH*
12+
113
* Truncate broadcast logging messages.
214

315
*J Smith*

0 commit comments

Comments
 (0)